Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @pyohannes as owner of EC2/ECS/EKS AWS detectors #5656

Merged
merged 12 commits into from
May 31, 2024
Merged
9 changes: 0 additions & 9 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- The `go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5551]. (#5598)
- The `go.opentelemetry.io/contrib/detectors/aws/ec2` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5542]. (#5636)
- The `go.opentelemetry.io/contrib/detectors/aws/ecs` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5543]. (#5637)
- The `go.opentelemetry.io/contrib/detectors/aws/eks` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5544]. (#5640)
- The `go.opentelemetry.io/contrib/detectors/aws/lambda` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5545]. (#5641)
- The `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda` package is deprecated.
Expand All @@ -44,9 +38,6 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The `go.opentelemetry.io/contrib/samplers/aws/xray` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5554]. (#5647)

[#5542]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5542
[#5543]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5543
[#5544]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5544
[#5545]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5545
[#5546]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5546
[#5547]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5547
Expand Down
5 changes: 4 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ bridges/otelzap/ @open-te

config/ @open-telemetry/go-approvers @MadVikingGod @pellared @codeboten

detectors/aws/ @open-telemetry/go-approvers
detectors/aws/ec2 @open-telemetry/go-approvers @pyohannes
detectors/aws/ecs @open-telemetry/go-approvers @pyohannes
detectors/aws/eks @open-telemetry/go-approvers @pyohannes
detectors/aws/lambda @open-telemetry/go-approvers
detectors/gcp/ @open-telemetry/go-approvers @dashpole

exporters/autoexport @open-telemetry/go-approvers @MikeGoldsmith @pellared
Expand Down
9 changes: 0 additions & 9 deletions detectors/aws/ec2/ec2.go
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// Package ec2 provide an OpenTelemetry resource detector for AWS EC2
// instances.
//
// Deprecated: ec2 has no Code Owner.
// After August 21, 2024, it may no longer be supported and may stop
// receiving new releases unless a new Code Owner is found. See
// [this issue] if you would like to become the Code Owner of this module.
//
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5542
package ec2 // import "go.opentelemetry.io/contrib/detectors/aws/ec2"

import (
Expand Down
1 change: 0 additions & 1 deletion detectors/aws/ec2/go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Deprecated: ec2 has no Code Owner.
module go.opentelemetry.io/contrib/detectors/aws/ec2

go 1.21
Expand Down
9 changes: 0 additions & 9 deletions detectors/aws/ecs/ecs.go
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// Package ecs provide an OpenTelemetry resource detector for AWS ECS
// instances.
//
// Deprecated: ecs has no Code Owner.
// After August 21, 2024, it may no longer be supported and may stop
// receiving new releases unless a new Code Owner is found. See
// [this issue] if you would like to become the Code Owner of this module.
//
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5543
package ecs // import "go.opentelemetry.io/contrib/detectors/aws/ecs"

import (
Expand Down
1 change: 0 additions & 1 deletion detectors/aws/ecs/go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Deprecated: ecs has no Code Owner.
module go.opentelemetry.io/contrib/detectors/aws/ecs

go 1.21
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/ecs/test/ecs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"strings"
"testing"

ecs "go.opentelemetry.io/contrib/detectors/aws/ecs" // nolint:staticcheck // deprecated.
ecs "go.opentelemetry.io/contrib/detectors/aws/ecs"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/sdk/resource"
semconv "go.opentelemetry.io/otel/semconv/v1.25.0"
Expand Down
9 changes: 0 additions & 9 deletions detectors/aws/eks/detector.go
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// Package eks provide an OpenTelemetry resource detector for AWS EKS
// instances.
//
// Deprecated: eks has no Code Owner.
// After August 21, 2024, it may no longer be supported and may stop
// receiving new releases unless a new Code Owner is found. See
// [this issue] if you would like to become the Code Owner of this module.
//
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5544
package eks // import "go.opentelemetry.io/contrib/detectors/aws/eks"

import (
Expand Down
1 change: 0 additions & 1 deletion detectors/aws/eks/go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Deprecated: eks has no Code Owner.
module go.opentelemetry.io/contrib/detectors/aws/eks

go 1.21
Expand Down