[chore]: enable error-is-as rule from testifylint

Signed-off-by: Matthieu MOREL <[email protected]>
open-telemetry · Sep 22, 2024 · 028cc9b · 028cc9b
1 parent c5d8ab9
commit 028cc9b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -248,7 +248,6 @@ linters-settings:
     enable-all: true
     disable:
       - compares
-      - error-is-as
       - expected-actual
       - float-compare
       - formatter

diff --git a/samplers/probability/consistent/tracestate_test.go b/samplers/probability/consistent/tracestate_test.go
@@ -4,7 +4,6 @@
 package consistent
 
 import (
-	"errors"
 	"strconv"
 	"strings"
 	"testing"
@@ -91,7 +90,7 @@ func TestParseTraceStateUnsampled(t *testing.T) {
 			require.False(t, otts.hasPValue(), "should have no p-value")
 
 			if test.expectErr != nil {
-				require.True(t, errors.Is(err, test.expectErr), "not expecting %v", err)
+				require.ErrorIs(t, err, test.expectErr, "not expecting %v", err)
 			}
 			if test.rval != notset {
 				require.True(t, otts.hasRValue())
@@ -168,7 +167,7 @@ func TestParseTraceStateSampled(t *testing.T) {
 			otts, err := parseOTelTraceState(test.in, true)
 
 			if test.expectErr != nil {
-				require.True(t, errors.Is(err, test.expectErr), "not expecting %v", err)
+				require.ErrorIs(t, err, test.expectErr, "not expecting %v", err)
 			} else {
 				require.NoError(t, err)
 			}
@@ -252,7 +251,7 @@ func TestParseTraceStateExtra(t *testing.T) {
 			otts, err := parseOTelTraceState(test.in, test.sampled)
 
 			if test.expectErr != nil {
-				require.True(t, errors.Is(err, test.expectErr), "not expecting %v", err)
+				require.ErrorIs(t, err, test.expectErr, "not expecting %v", err)
 			} else {
 				require.NoError(t, err)
 			}