Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elastic Search exporter follow ECS guidelines #3107

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Elastic Search exporter follow ECS guidelines #3107

wants to merge 6 commits into from

Commits on Oct 18, 2024

  1. [EXPORTERS]: elastic search log message within message key instead of 

    `body`

According to ECS logging reference
https://www.elastic.co/guide/en/ecs/8.11/ecs-base.html#field-message

Refs open-telemetry#3091
    @ShadowMaxLeb
    ShadowMaxLeb committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3c450ef View commit details
    Browse the repository at this point in the history

  2. [EXPORTERS]: elastic search set severity within log.level key inste… 

    …ad of

    `severity`

According to ECS logging reference
https://www.elastic.co/guide/en/ecs/8.11/ecs-log.html#field-log-level

Refs open-telemetry#3091
    @ShadowMaxLeb
    ShadowMaxLeb committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8be43d2 View commit details
    Browse the repository at this point in the history

  3. [EXPORTERS]: elastic search set timestamp within @timestamp instead of 

    `timestamp`

Also changes the format to be a Date string.

According to ECS logging reference
https://www.elastic.co/guide/en/ecs/8.11/ecs-base.html#field-timestamp

Refs open-telemetry#3091
    @ShadowMaxLeb
    ShadowMaxLeb committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    53d72bf View commit details
    Browse the repository at this point in the history

  4. [EXPORTERS]: elastic search set instrumentation scope within `log.log… 

    …ger` instead of

`name`

According to ECS logging reference
https://www.elastic.co/guide/en/ecs/8.11/ecs-log.html#field-log-logger

Refs open-telemetry#3091
    @ShadowMaxLeb
    ShadowMaxLeb committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ff35e7a View commit details
    Browse the repository at this point in the history

  5. EXPORTERS]: elastic search recorable constructor sets ecs.version f… 

    …ield

to 8.11.0

According to ECS guidelines this field is mandatory
https://www.elastic.co/guide/en/ecs/8.11/ecs-guidelines.html

Refs open-telemetry#3091
    @ShadowMaxLeb
    ShadowMaxLeb committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    401ad81 View commit details
    Browse the repository at this point in the history

  6. [EXPORTERS]: elastic search put attributes in json root instead of under 

    `attributes`

This allows user to set other fields that are part of the [ECS log documentation](https://www.elastic.co/guide/en/ecs/8.11/ecs-log.html).
For instance, it allows to have an attribute with key `log.file`, that
will, thanks to `nlohmann::json`, appear as :
```
{
  "log": {
    "file": "xxx"
  }
}
```

Closes open-telemetry#3091
    @ShadowMaxLeb
    ShadowMaxLeb committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6d72624 View commit details
    Browse the repository at this point in the history