Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2661

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

hongweipeng
Copy link
Contributor

@hongweipeng hongweipeng commented May 7, 2024

Fixes #2660

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@hongweipeng hongweipeng requested a review from a team May 7, 2024 07:26
Copy link

linux-foundation-easycla bot commented May 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hongweipeng / name: Weipeng Hong (6b44492)
  • ✅ login: marcalff / name: Marc Alff (1f404a3)

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label May 7, 2024
@marcalff marcalff removed the pr:waiting-on-cla Waiting on CLA label May 7, 2024
@hongweipeng hongweipeng force-pushed the fix-random-memory-leak branch 3 times, most recently from cdffe88 to 9ebc698 Compare May 8, 2024 04:02
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff changed the title Fix memory leak in TlsRandomNumberGenerator() constructor #2660 [SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2660 Jul 19, 2024
@marcalff marcalff changed the title [SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2660 [SDK] Fix memory leak in TlsRandomNumberGenerator() constructor Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (497eaf4) to head (1f404a3).
Report is 108 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
+ Coverage   87.12%   87.60%   +0.49%     
==========================================
  Files         200      190      -10     
  Lines        6109     5870     -239     
==========================================
- Hits         5322     5142     -180     
+ Misses        787      728      -59     
Files Coverage Δ
sdk/src/common/random.cc 96.00% <100.00%> (+0.17%) ⬆️

... and 121 files with indirect coverage changes

@marcalff marcalff merged commit deed1e3 into open-telemetry:main Jul 19, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TlsRandomNumberGenerator() can cause memory leaks
5 participants