Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Clang-15 warning about __has_trivial_destructor #2321

Closed
timwoj opened this issue Sep 21, 2023 · 3 comments · Fixed by #2502
Closed

[BUILD] Clang-15 warning about __has_trivial_destructor #2321

timwoj opened this issue Sep 21, 2023 · 3 comments · Fixed by #2502
Assignees
Labels
bug Something isn't working do-not-stale Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@timwoj
Copy link
Contributor

timwoj commented Sep 21, 2023

This popped up after upgrading to XCode 15.0 on macOS. I'm building against otel-cpp release v1.11.0.

Steps to reproduce
Build otel-cpp

What is the expected behavior?
No warnings.

What is the actual behavior?

/Users/tim/Desktop/projects/zeek/auxil/opentelemetry-cpp/api/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:299:36: warning: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Wdeprecated-builtins]
    : std::integral_constant<bool, __has_trivial_destructor(T) &&
                                   ^
/Users/tim/Desktop/projects/zeek/auxil/opentelemetry-cpp/api/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:348:36: warning: builtin __has_trivial_constructor is deprecated; use __is_trivially_constructible instead [-Wdeprecated-builtins]
    : std::integral_constant<bool, __has_trivial_constructor(T) &&
                                   ^
/Users/tim/Desktop/projects/zeek/auxil/opentelemetry-cpp/api/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:492:17: warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins]
          bool, __has_trivial_assign(typename std::remove_reference<T>::type) &&
                ^
/Users/tim/Desktop/projects/zeek/auxil/opentelemetry-cpp/api/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:536:8: warning: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Wdeprecated-builtins]
      (__has_trivial_copy(ExtentsRemoved) || !kIsCopyOrMoveConstructible) &&
       ^
/Users/tim/Desktop/projects/zeek/auxil/opentelemetry-cpp/api/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:537:8: warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins]
      (__has_trivial_assign(ExtentsRemoved) || !kIsCopyOrMoveAssignable) &&
       ^
@timwoj timwoj added the bug Something isn't working label Sep 21, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 21, 2023
@marcalff marcalff self-assigned this Sep 21, 2023
@lalitb
Copy link
Member

lalitb commented Sep 22, 2023

These seems to be deprecated from clang15 onwards. Probably, we can pickup the relevant changes from here -

abseil/abseil-cpp@cfe27e7

@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 25, 2023
Copy link

This issue was marked as stale due to lack of activity.

@timwoj
Copy link
Contributor Author

timwoj commented Jan 9, 2024

Can this be looked at for an upcoming release?

@marcalff marcalff changed the title Warning about __has_trivial_destructor with newer compilers Clang-15 warning about __has_trivial_destructor Jan 22, 2024
@marcalff marcalff changed the title Clang-15 warning about __has_trivial_destructor [BUILD] Clang-15 warning about __has_trivial_destructor Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do-not-stale Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants