Skip to content

Commit

Permalink
Build cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
marcalff committed Jul 10, 2023
1 parent 31f4288 commit f17d932
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions api/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ endif()
if(WITH_REMOVE_METER_PREVIEW)
target_compile_definitions(opentelemetry_api
INTERFACE ENABLE_REMOVE_METER_PREVIEW)
endif()

if(WITH_ABI_VERSION_2)
target_compile_definitions(opentelemetry_api
INTERFACE OPENTELEMETRY_ABI_VERSION_NO=2)
Expand Down
7 changes: 4 additions & 3 deletions docs/abi-version-policy.md
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,8 @@ to follow specification changes.

See the issue description for all details:

* [Metrics API/SDK] Add InstrumentationScope attributes in MeterProvider::GetMeter() #2033
* [Metrics API/SDK]
Add InstrumentationScope attributes in MeterProvider::GetMeter() #2033

#### API change

Expand Down Expand Up @@ -471,7 +472,7 @@ change in the caller when providing up to 3 parameters.

In the SDK class declaration, implement the expected API.

```
```cpp
class MeterProvider final : public opentelemetry::metrics::MeterProvider
{
public:
Expand Down Expand Up @@ -500,7 +501,7 @@ In the SDK implementation:
* either get the new parameters from the extended ABI v2 method
* or provide default values for the old ABI v1 method

```
```cpp
nostd::shared_ptr<metrics_api::Meter> MeterProvider::GetMeter(
nostd::string_view name,
nostd::string_view version,
Expand Down

0 comments on commit f17d932

Please sign in to comment.