Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify error message when connector ID must be disambiguated #8121

Merged

Conversation

djaglowski
Copy link
Member

Resolves #8120

@djaglowski djaglowski requested a review from mx-psi July 21, 2023 15:02
@djaglowski
Copy link
Member Author

This is technically user facing but in my opinion is minor enough that it does not warrant a changelog. Happy to add one if maintainers disagree.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (a1efc0e) 90.18% compared to head (bfcdf82) 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8121      +/-   ##
==========================================
+ Coverage   90.18%   90.24%   +0.06%     
==========================================
  Files         301      301              
  Lines       15377    15453      +76     
==========================================
+ Hits        13868    13946      +78     
+ Misses       1222     1221       -1     
+ Partials      287      286       -1     
Impacted Files Coverage Δ
otelcol/config.go 100.00% <100.00%> (ø)
service/internal/proctelemetry/config.go 96.75% <100.00%> (+2.06%) ⬆️
service/telemetry/config.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Agreed that no changelog is needed

@djaglowski djaglowski marked this pull request as ready for review July 21, 2023 15:28
@djaglowski djaglowski requested a review from a team July 21, 2023 15:28
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 21, 2023
@codeboten codeboten merged commit a18c67d into open-telemetry:main Jul 21, 2023
32 of 35 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[otelcol] Improve error message when connectors lead to ambiguous IDs
3 participants