Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OTLP export support for internal traces #8119

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Jul 20, 2023

This PR adds support for exporting internal collector traces via the
OTel Go OTLP exporters.

Closes #8106

Follows #8117

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 98.34% and no project coverage change.

Comparison is base (2c2a27a) 90.18% compared to head (c5cfb2c) 90.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8119   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         302      302           
  Lines       15766    15854   +88     
=======================================
+ Hits        14218    14298   +80     
- Misses       1254     1261    +7     
- Partials      294      295    +1     
Files Changed Coverage Δ
service/internal/proctelemetry/config.go 96.38% <98.05%> (+0.38%) ⬆️
service/telemetry/config.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten force-pushed the codeboten/add-otlp-trace-exporter branch 2 times, most recently from 3901b84 to 411ab40 Compare July 21, 2023 21:45
@codeboten codeboten marked this pull request as ready for review July 21, 2023 21:45
@codeboten codeboten requested review from a team and bogdandrutu July 21, 2023 21:45
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 8, 2023
@codeboten codeboten removed the Stale label Aug 15, 2023
@codeboten codeboten force-pushed the codeboten/add-otlp-trace-exporter branch from 0b7e951 to 0a57365 Compare August 15, 2023 15:15
service/internal/proctelemetry/config.go Outdated Show resolved Hide resolved
service/internal/proctelemetry/config.go Outdated Show resolved Hide resolved
service/internal/proctelemetry/config.go Outdated Show resolved Hide resolved
service/internal/proctelemetry/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fun to me, I do suggest adding the checks for Timeout > 0 to avoid issues were the gRPC starts correctly but does not work because it will always timeout.

Alex Boten and others added 4 commits August 23, 2023 13:44
This PR adds support for exporting internal collector traces via the
OTel Go OTLP exporters.

Closes open-telemetry#8106

Signed-off-by: Alex Boten <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
@codeboten codeboten force-pushed the codeboten/add-otlp-trace-exporter branch from 410a728 to c5cfb2c Compare August 23, 2023 20:44
@codeboten codeboten merged commit f453c51 into open-telemetry:main Aug 24, 2023
30 checks passed
@codeboten codeboten deleted the codeboten/add-otlp-trace-exporter branch August 24, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support additional exporters for exporting collector traces
6 participants