-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OTLP export support for internal traces #8119
add OTLP export support for internal traces #8119
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8119 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 302 302
Lines 15766 15854 +88
=======================================
+ Hits 14218 14298 +80
- Misses 1254 1261 +7
- Partials 294 295 +1
☔ View full report in Codecov by Sentry. |
3901b84
to
411ab40
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
0b7e951
to
0a57365
Compare
793ee53
to
d6032c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fun to me, I do suggest adding the checks for Timeout > 0
to avoid issues were the gRPC starts correctly but does not work because it will always timeout.
This PR adds support for exporting internal collector traces via the OTel Go OTLP exporters. Closes open-telemetry#8106 Signed-off-by: Alex Boten <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
410a728
to
c5cfb2c
Compare
This PR adds support for exporting internal collector traces via the
OTel Go OTLP exporters.
Closes #8106
Follows #8117