-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service] Split component.Host
functionality into separate serviceHost
struct
#5292
[service] Split component.Host
functionality into separate serviceHost
struct
#5292
Conversation
component.Host
functionality into separate service.Host
component.Host
functionality into separate serviceHost
struct
Codecov Report
@@ Coverage Diff @@
## main #5292 +/- ##
==========================================
- Coverage 90.57% 90.56% -0.01%
==========================================
Files 189 190 +1
Lines 11116 11113 -3
==========================================
- Hits 10068 10065 -3
Misses 826 826
Partials 222 222
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment
@mx-psi I would kindly ask you in a followup PR to split tests (make them really unit tests)... Pretty please 🙏 |
You mean moving the |
@mx-psi you are on spot :) Also may require some refactoring :)))) |
I have 15 things in flight that I need to tackle before going on PTO next week, so I put this on an issue so that I don't forget about it :) |
Description:
Moves
service
functionality related tocomponent.Host
andzpages
into a newserviceHost
struct. This is an internal refactor only, with the goal of more easily visualizing what it would take to eventually expose theservice
struct.Link to tracking Issue: I opened this because of the discussion in #5149. I want to do internal refactors to move towards eventually exposing
service
. Even if we don't end up going in that route, I think this is an improvement of the code and should be merged regardless.Testing: Amended unit tests
Documentation: n/a, internal refactor only