Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide profiles behind a feature gate #11477

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

dmathieu
Copy link
Member

Description

This hides profiles support behind a feature gate, so folks have to enable them explicitly to be able to use them.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.14%. Comparing base (4dbbb90) to head (22b4c6e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11477   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files         433      433           
  Lines       20389    20396    +7     
=======================================
+ Hits        18787    18794    +7     
  Misses       1238     1238           
  Partials      364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review October 17, 2024 09:08
@dmathieu dmathieu requested a review from a team as a code owner October 17, 2024 09:08
@dmathieu dmathieu requested a review from mx-psi October 17, 2024 09:08
@bogdandrutu bogdandrutu merged commit 3456b43 into open-telemetry:main Oct 17, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 17, 2024
@dmathieu dmathieu deleted the featuregate-profiles branch October 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants