-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otelcol] Preserve internal representation for components' configurations #10897
[otelcol] Preserve internal representation for components' configurations #10897
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10897 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.01%
==========================================
Files 404 404
Lines 18980 18983 +3
==========================================
+ Hits 17387 17388 +1
- Misses 1234 1235 +1
- Partials 359 360 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated code is out of date, please run "make gogenerate" and commit the changes in this PR.
Just comments from failing check and lint.
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Description
The custom unmarshalling for components copied a map without preserving the internal representation. This led to the issues mentioned on #10552 not being fully fixed (they were only fixed if they happened in the
service::telemetry
section for example).Link to tracking issue
Fixes issues mentioned on #10552
Testing
This adds one unit test at the
otelcol
level. Since we didn't catch this with our currentconfmap/internal/e2e
tests, we likely also want to refactor those.