Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] export ScopeName in internal/metadata package #10845

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Aug 8, 2024

This can be used by components that need to set their scope name manually. Will save component owners from having to store a variable, which may diverge from the scope name used by the component for emitting its own telemetry. There are about a dozen components in contrib that could use this today.

Alternatively, I could just update the scope name strings in the components manually.

This can be used by components that need to set their scope name manually. Will save component owners from having to store a variable, which may diverge from the scope name used by the component for emitting its own telemetry.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested review from a team and dmitryax August 8, 2024 21:39
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (ecbe02e) to head (0c5593f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10845   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         406      406           
  Lines       19001    19001           
=======================================
  Hits        17414    17414           
  Misses       1227     1227           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems helpful to me

@codeboten codeboten merged commit 7638bb2 into open-telemetry:main Aug 9, 2024
50 checks passed
@codeboten codeboten deleted the codeboten/mdatagen-expose-scope-name branch August 9, 2024 15:12
@github-actions github-actions bot added this to the next release milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants