Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelcol] Fix grpclogger to capture correct caller location #10773

Merged

Conversation

vvs-personalstash
Copy link
Contributor

@vvs-personalstash vvs-personalstash commented Jul 31, 2024

Description

Cleaned up Grpc logs to make them reference the location where the log statements are written instead of zapgrpc/zapgrpc.go:176

Link to tracking issue

Fixes #10772
Fixes jaegertracing/jaeger#5784

@vvs-personalstash vvs-personalstash requested review from a team and codeboten July 31, 2024 18:05
Copy link

linux-foundation-easycla bot commented Jul 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@yurishkuro
Copy link
Member

Please give a proper title to the PR.

@vvs-personalstash vvs-personalstash changed the title Update logger.go [Component]Fixed up grpclogger making unwanted references to zapgrpc Jul 31, 2024
@vvs-personalstash vvs-personalstash changed the title [Component]Fixed up grpclogger making unwanted references to zapgrpc [component]Fixed up grpclogger making unwanted references to zapgrpc in logs Jul 31, 2024
@vvs-personalstash vvs-personalstash changed the title [component]Fixed up grpclogger making unwanted references to zapgrpc in logs [otelcol]Fixed up grpclogger making unwanted references to zapgrpc in logs Jul 31, 2024
@yurishkuro yurishkuro changed the title [otelcol]Fixed up grpclogger making unwanted references to zapgrpc in logs [otelcol] Fix grpclogger to capture correct caller location Jul 31, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (dadc331) to head (6b01567).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10773   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         411      411           
  Lines       19318    19318           
=======================================
  Hits        17752    17752           
  Misses       1217     1217           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 8, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 23, 2024
@github-actions github-actions bot removed the Stale label Aug 24, 2024
@yurishkuro
Copy link
Member

@open-telemetry/collector-maintainers can this be merged?

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten codeboten merged commit 93ecf69 into open-telemetry:main Aug 26, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 26, 2024
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up gRPC logging [v2] Clean up gRPC logging
3 participants