Skip to content

Commit

Permalink
[chore] update jsonschema (#8046)
Browse files Browse the repository at this point in the history
- `make genjsonschema`
- remove duplicate type

---------

Signed-off-by: Alex Boten <[email protected]>
  • Loading branch information
Alex Boten authored Jul 12, 2023
1 parent 6f8ad88 commit 05fe5fa
Show file tree
Hide file tree
Showing 3 changed files with 365 additions and 138 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: service

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "Remove experimental `metric_readers.args` and `metric_reader.type` config options."

# One or more tracking issues or pull requests related to the change
issues: []

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
These options were experimental and did not have any effect on the configuration of
the collector's telemetry. The change aligns the configuration with the latest iteration
of the configuration json schema, which may still change in the future.
13 changes: 0 additions & 13 deletions service/telemetry/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,19 +93,6 @@ type LogsSamplingConfig struct {
Thereafter int `mapstructure:"thereafter"`
}

// MetricReader exposes configuration of metric readers to end users.
// TODO: replace this temporary struct w/ auto-generated struct from jsonschema
// https://github.com/open-telemetry/opentelemetry-configuration/tree/main/schema
//
// Experimental: *NOTE* this structure is subject to change or removal in the future.
type MetricReader struct {
// Args corresponds to the JSON schema field "args".
Args any `mapstructure:"args"`

// Type corresponds to the JSON schema field "type".
Type string `mapstructure:"type"`
}

// MetricsConfig exposes the common Telemetry configuration for one component.
// Experimental: *NOTE* this structure is subject to change or removal in the future.
type MetricsConfig struct {
Expand Down
Loading

0 comments on commit 05fe5fa

Please sign in to comment.