Merge pull request #71 from oslabs-beta/drew/readme

Drew/readme
open-source-labs · Dec 15, 2022 · 50fa8cf · 50fa8cf
2 parents 47d7a02 + 8c778be
commit 50fa8cf
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -174,6 +174,11 @@ npm run test
 Read our [contributing guide](https://github.com/open-source-labs/Docketeer/blob/master/CONTRIBUTING.md) for more information on how to purpose bugfixes and improvements to Docketeer.
 
 ### Authors
+- Sarah Moosa [@Sbethm](https://github.com/Sbethm) | [LinkedIn](https://www.linkedin.com/in/sarah-moosa-4b05721b6/)
+- Cedar Cooper [@CedarCooper](https://github.com/CedarCooper) | [LinkedIn](https://www.linkedin.com/in/cedar-cooper/)
+- Tiffany Chau [@tiffanynchau](https://github.com/tiffanynchau/) | [LinkedIn](https://www.linkedin.com/in/tiffanynchau/)
+- Jack Yuan [@jackyuan1](https://github.com/jackyuan1) | [LinkedIn](https://www.linkedin.com/in/jack-yuan-298244247/)
+- Drew Manley [@DrewManley](https://github.com/DrewManley) | [LinkedIn](https://www.linkedin.com/in/andrewmanley13/)
 - Abigail Gerig [@4estgirl](https://github.com/4estgirl) | [Linkedin](https://www.linkedin.com/in/abigail-gerig/)
 - Trine Medina [@TrineMedina](https://github.com/TrineMedina) | [Linkedin](https://www.linkedin.com/in/trinemedina/)
 - Christian Looff [@cmlooff](https://github.com/cmlooff) | [LinkedIn](https://www.linkedin.com/in/christian-looff/)

diff --git a/src/components/helper/commands.tsx b/src/components/helper/commands.tsx
@@ -53,7 +53,7 @@ export const addRunning = (runningList, callback) => {
         }
         isInTheList ? '' : newList.push(convertedValue[i]);
       }
-      console.log('addrunning newlist', newList);
+      // console.log('addrunning newlist', newList);
       newList.length ? callback(newList) : '';
     }
   );
@@ -242,7 +242,11 @@ export const runStopped = (
 export const runIm = (container, runningList, callback_1, callback_2) => {
   // props.runIm(ele['imgid'], props.runningList, helper.addRunning, props.addRunningContainers)
   const { imgid, reps, tag } = container;
-  window.nodeMethod.runExec(`docker run --name ${reps}-${tag} ${reps}:${tag}`, (error, stdout, stderr) => {
+  const containerId = Math.floor(Math.random() * 100)
+  const filteredRepo = reps
+  .replace(/[,\/#!$%\^&\*;:{}=\`~()]/g, ".")
+  .replace(/\s{2,}/g, " ");
+  window.nodeMethod.runExec(`docker run --name ${filteredRepo}-${tag}_${containerId} ${reps}:${tag}`, (error, stdout, stderr) => {
     if (error) {
       alert(`${error.message}`);
       return;

diff --git a/src/main/index.ts b/src/main/index.ts
@@ -29,7 +29,7 @@ function createMainWindow() {
 
   if (process.env.NODE_ENV === 'development') {
     mainWindow.loadURL(`http://localhost:4000`);
-    mainWindow.webContents.openDevTools()
+    // mainWindow.webContents.openDevTools()
   } else {
     mainWindow.loadURL(
       url.format({