support jazzy #955

koonpeng · 2024-06-12T05:41:48Z

What's new

Update to noble+jazzy.

Build a minimal rmf image because the rmf demos image is not yet updated to jazzy, also it's huge.
Update all workflows to use that minimal image.
Update references of humble to jazzy.
Cleanup workflows.
bootstrap venv + pipenv because pip no longer allows installing to system packages in noble

Self-checks

I have prototyped this new feature (if necessary) on Figma
I'm familiar with and follow this Typescript guideline
I added unit-tests for new components
I tried testing edge cases
I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Teo Koon Peng <[email protected]>

README.md

aaronchongth

While running simulation tests, I noticed that

the simulation is already running, then only we start the api-server, it will segfault
after starting the api-server, then starting the simulation, the segfault occurs when a task is dispatched

koonpeng · 2024-06-26T07:53:26Z

By segfault, you mean that rmf crashes? Let me see if I can reproduce it.

koonpeng · 2024-06-26T08:23:45Z

Not able to reproduce it, though I get a different error

[fleet_adapter-14] Other error for tinyRobot2 in get_data: 'robot_name'

aaronchongth · 2024-06-27T02:27:08Z

Sorry that was cryptic of me, I mean't api-server crashes. Let me attach some screenshots

As for the different error, it looks like you may have an outdated workspace, I remember seeing this error before I rebuilt off main for everything

Co-authored-by: Aaron Chong <[email protected]>

Signed-off-by: Teo Koon Peng <[email protected]>

koonpeng · 2024-06-27T03:14:55Z

I'm not able to reproduce it, I can run with sim and managed to send a task. It could be due to some dependency conflict, python shouldn't normally segfault.

aaronchongth

Thanks for supporting this! LGTM

Looks like our migration effort of deployment branches have more to keep up with!

edit: not sure what was wrong with my setup, but after a full restart, rebuilding of my RMF workspace off main, and rmf-web of your branch, things are working well again.

Signed-off-by: Aaron Chong <[email protected]>

…ble" This reverts commit 1fd22ee.

…ble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <[email protected]>

* First iteration of generic alerts Signed-off-by: Aaron Chong <[email protected]> * Route for unresponded alerts Signed-off-by: Aaron Chong <[email protected]> * Basic location complete post route for task Signed-off-by: Aaron Chong <[email protected]> * Tests for alert routes Signed-off-by: Aaron Chong <[email protected]> * Test for location complete route Signed-off-by: Aaron Chong <[email protected]> * Lint and tests Signed-off-by: Aaron Chong <[email protected]> * Basic implementation Signed-off-by: Aaron Chong <[email protected]> * Basic task based alerts working as expected Signed-off-by: Aaron Chong <[email protected]> * Only display and list alerts that have display true Signed-off-by: Aaron Chong <[email protected]> * Add doc to location_complete route about instability Signed-off-by: Aaron Chong <[email protected]> * Refactored alert db interactions to repository, with lru cache for location alerts checking Signed-off-by: Aaron Chong <[email protected]> * Regenerated docs and return early on gateway last location checking Signed-off-by: Aaron Chong <[email protected]> * Lint and better typing with static methods Signed-off-by: Aaron Chong <[email protected]> * Hammer/generic alerts without location (#951) * First round of cleanup Signed-off-by: Aaron Chong <[email protected]> * Regenerate API Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> * Hammer/demo tasks (#925) * Moved custom deliveries to separate file naively and import naively Signed-off-by: Aaron Chong <[email protected]> * Moved patrol Signed-off-by: Aaron Chong <[email protected]> * Moved custom-compose Signed-off-by: Aaron Chong <[email protected]> * Added clean and delivery Signed-off-by: Aaron Chong <[email protected]> * Added delivery, renamed to SimpleDelivery Signed-off-by: Aaron Chong <[email protected]> * Clean task added Signed-off-by: Aaron Chong <[email protected]> * Moved delivery-custom tests, added return type for forms Signed-off-by: Aaron Chong <[email protected]> * Configurable supported tasks and name remapping Signed-off-by: Aaron Chong <[email protected]> * Changed directory to types, since it doesn't just handle descriptions Signed-off-by: Aaron Chong <[email protected]> * Fix test imports Signed-off-by: Aaron Chong <[email protected]> * Using temporary task definition Signed-off-by: Aaron Chong <[email protected]> * Refactoring new rename changes Signed-off-by: Aaron Chong <[email protected]> * Clean up Signed-off-by: Aaron Chong <[email protected]> * Removed problematic and unsused component and test Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Updating pnpm version in github workflow Signed-off-by: Aaron Chong <[email protected]> * Reverting update to pnpm version Signed-off-by: Aaron Chong <[email protected]> * Fix build now that we use key value strings for labels Signed-off-by: Aaron Chong <[email protected]> * Refactored last parts of hard coding categories and rendering forms Signed-off-by: Aaron Chong <[email protected]> * Refactor callback names and error handling for misconfigs Signed-off-by: Aaron Chong <[email protected]> * Display error as well Signed-off-by: Aaron Chong <[email protected]> * Fixed more checks and failures Signed-off-by: Aaron Chong <[email protected]> * Split configuration and definition, only handle configurations in resource manager level Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Not using object as a type Signed-off-by: Aaron Chong <[email protected]> * Address feedback Signed-off-by: Aaron Chong <[email protected]> * Render using validTasks instead Signed-off-by: Aaron Chong <[email protected]> * Use useMemo Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> * Update ros2 pydantic messages, fix tests Signed-off-by: Aaron Chong <[email protected]> * Revert update of pnpm lock file Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Use specific exceptions and more clean up Signed-off-by: Aaron Chong <[email protected]> * Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble Signed-off-by: Aaron Chong <[email protected]> * Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <[email protected]> * Update pnpm version Signed-off-by: Aaron Chong <[email protected]> * Setup pnpm and node manually Signed-off-by: Aaron Chong <[email protected]> * Using HOME env var of runner Signed-off-by: Aaron Chong <[email protected]> * workflow Signed-off-by: Aaron Chong <[email protected]> * workflow Signed-off-by: Aaron Chong <[email protected]> * Workflow Signed-off-by: Aaron Chong <[email protected]> * Address feedback on frontend Signed-off-by: Aaron Chong <[email protected]> * Address comments that don't break behavior Signed-off-by: Aaron Chong <[email protected]> * Started generic exceptions Signed-off-by: Aaron Chong <[email protected]> * Proper db schema for alert request and response Signed-off-by: Aaron Chong <[email protected]> * Updated alerts model, frontend tweaks for subscription, using pagination for unackw query, updated API Signed-off-by: Aaron Chong <[email protected]> * Attempt to setup minimal RMF during bootstrap step Signed-off-by: Aaron Chong <[email protected]> * Fix mistake on ci path Signed-off-by: Aaron Chong <[email protected]> * Fix workflow Signed-off-by: Aaron Chong <[email protected]> * Revert CI changes Signed-off-by: Aaron Chong <[email protected]> * Updated API, renamed event to pushAlert, filter before Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>

* First iteration of generic alerts Signed-off-by: Aaron Chong <[email protected]> * Route for unresponded alerts Signed-off-by: Aaron Chong <[email protected]> * Basic location complete post route for task Signed-off-by: Aaron Chong <[email protected]> * Tests for alert routes Signed-off-by: Aaron Chong <[email protected]> * Test for location complete route Signed-off-by: Aaron Chong <[email protected]> * Lint and tests Signed-off-by: Aaron Chong <[email protected]> * Basic implementation Signed-off-by: Aaron Chong <[email protected]> * Basic task based alerts working as expected Signed-off-by: Aaron Chong <[email protected]> * Only display and list alerts that have display true Signed-off-by: Aaron Chong <[email protected]> * Add doc to location_complete route about instability Signed-off-by: Aaron Chong <[email protected]> * Refactored alert db interactions to repository, with lru cache for location alerts checking Signed-off-by: Aaron Chong <[email protected]> * Regenerated docs and return early on gateway last location checking Signed-off-by: Aaron Chong <[email protected]> * Lint and better typing with static methods Signed-off-by: Aaron Chong <[email protected]> * Hammer/generic alerts without location (#951) * First round of cleanup Signed-off-by: Aaron Chong <[email protected]> * Regenerate API Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> * Hammer/demo tasks (#925) * Moved custom deliveries to separate file naively and import naively Signed-off-by: Aaron Chong <[email protected]> * Moved patrol Signed-off-by: Aaron Chong <[email protected]> * Moved custom-compose Signed-off-by: Aaron Chong <[email protected]> * Added clean and delivery Signed-off-by: Aaron Chong <[email protected]> * Added delivery, renamed to SimpleDelivery Signed-off-by: Aaron Chong <[email protected]> * Clean task added Signed-off-by: Aaron Chong <[email protected]> * Moved delivery-custom tests, added return type for forms Signed-off-by: Aaron Chong <[email protected]> * Configurable supported tasks and name remapping Signed-off-by: Aaron Chong <[email protected]> * Changed directory to types, since it doesn't just handle descriptions Signed-off-by: Aaron Chong <[email protected]> * Fix test imports Signed-off-by: Aaron Chong <[email protected]> * Using temporary task definition Signed-off-by: Aaron Chong <[email protected]> * Refactoring new rename changes Signed-off-by: Aaron Chong <[email protected]> * Clean up Signed-off-by: Aaron Chong <[email protected]> * Removed problematic and unsused component and test Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Updating pnpm version in github workflow Signed-off-by: Aaron Chong <[email protected]> * Reverting update to pnpm version Signed-off-by: Aaron Chong <[email protected]> * Fix build now that we use key value strings for labels Signed-off-by: Aaron Chong <[email protected]> * Refactored last parts of hard coding categories and rendering forms Signed-off-by: Aaron Chong <[email protected]> * Refactor callback names and error handling for misconfigs Signed-off-by: Aaron Chong <[email protected]> * Display error as well Signed-off-by: Aaron Chong <[email protected]> * Fixed more checks and failures Signed-off-by: Aaron Chong <[email protected]> * Split configuration and definition, only handle configurations in resource manager level Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Not using object as a type Signed-off-by: Aaron Chong <[email protected]> * Address feedback Signed-off-by: Aaron Chong <[email protected]> * Render using validTasks instead Signed-off-by: Aaron Chong <[email protected]> * Use useMemo Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> * Update ros2 pydantic messages, fix tests Signed-off-by: Aaron Chong <[email protected]> * Revert update of pnpm lock file Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Use specific exceptions and more clean up Signed-off-by: Aaron Chong <[email protected]> * Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble Signed-off-by: Aaron Chong <[email protected]> * Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <[email protected]> * Update pnpm version Signed-off-by: Aaron Chong <[email protected]> * Setup pnpm and node manually Signed-off-by: Aaron Chong <[email protected]> * Using HOME env var of runner Signed-off-by: Aaron Chong <[email protected]> * workflow Signed-off-by: Aaron Chong <[email protected]> * workflow Signed-off-by: Aaron Chong <[email protected]> * Workflow Signed-off-by: Aaron Chong <[email protected]> * Address feedback on frontend Signed-off-by: Aaron Chong <[email protected]> * Address comments that don't break behavior Signed-off-by: Aaron Chong <[email protected]> * Started generic exceptions Signed-off-by: Aaron Chong <[email protected]> * Proper db schema for alert request and response Signed-off-by: Aaron Chong <[email protected]> * Updated alerts model, frontend tweaks for subscription, using pagination for unackw query, updated API Signed-off-by: Aaron Chong <[email protected]> * Attempt to setup minimal RMF during bootstrap step Signed-off-by: Aaron Chong <[email protected]> * Fix mistake on ci path Signed-off-by: Aaron Chong <[email protected]> * Fix workflow Signed-off-by: Aaron Chong <[email protected]> * Revert CI changes Signed-off-by: Aaron Chong <[email protected]> * Updated API, renamed event to pushAlert, filter before Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 090dd9b) Signed-off-by: Aaron Chong <[email protected]>

koonpeng added 7 commits June 12, 2024 05:35

remove .venv

1753adc

Signed-off-by: Teo Koon Peng <[email protected]>

cleanup

33c93e3

Signed-off-by: Teo Koon Peng <[email protected]>

bootstrap pipenv in venv

8b0a947

Signed-off-by: Teo Koon Peng <[email protected]>

jazzy

c29ece0

Signed-off-by: Teo Koon Peng <[email protected]>

updating images

e74627d

Signed-off-by: Teo Koon Peng <[email protected]>

trigger workflow

6392073

Signed-off-by: Teo Koon Peng <[email protected]>

update workflow

557a1a8

Signed-off-by: Teo Koon Peng <[email protected]>

koonpeng force-pushed the koonpeng/jazzy branch 3 times, most recently from 1901214 to eee7fa3 Compare June 12, 2024 08:34

update scripts

191af6e

Signed-off-by: Teo Koon Peng <[email protected]>

koonpeng force-pushed the koonpeng/jazzy branch from eee7fa3 to 191af6e Compare June 12, 2024 08:36

koonpeng added 10 commits June 12, 2024 08:41

set concurrency

fdedec7

Signed-off-by: Teo Koon Peng <[email protected]>

update docker workflow

3cd5a4e

Signed-off-by: Teo Koon Peng <[email protected]>

update docker workflow

8b7772e

Signed-off-by: Teo Koon Peng <[email protected]>

trigger workflow

7afba7e

Signed-off-by: Teo Koon Peng <[email protected]>

fix source

b703bf8

Signed-off-by: Teo Koon Peng <[email protected]>

undo push nightly

96e1394

Signed-off-by: Teo Koon Peng <[email protected]>

update workflows

ffcaee9

Signed-off-by: Teo Koon Peng <[email protected]>

update workflows

513b19c

Signed-off-by: Teo Koon Peng <[email protected]>

update workflows

b138a39

Signed-off-by: Teo Koon Peng <[email protected]>

update workflows

1a94533

Signed-off-by: Teo Koon Peng <[email protected]>

koonpeng requested a review from aaronchongth June 12, 2024 10:09

koonpeng added 2 commits June 12, 2024 10:14

update workflows

d6775ce

Signed-off-by: Teo Koon Peng <[email protected]>

force install pipenv even if it already exist on the system

0224578

Signed-off-by: Teo Koon Peng <[email protected]>

aaronchongth approved these changes Jun 26, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

aaronchongth requested changes Jun 26, 2024

View reviewed changes

koonpeng and others added 2 commits June 27, 2024 11:02

Update README.md

5b7af0a

Co-authored-by: Aaron Chong <[email protected]>

Merge remote-tracking branch 'origin/main' into koonpeng/jazzy

a7feba4

Signed-off-by: Teo Koon Peng <[email protected]>

aaronchongth approved these changes Jul 1, 2024

View reviewed changes

aaronchongth merged commit 07f09ab into main Jul 1, 2024
7 checks passed

aaronchongth deleted the koonpeng/jazzy branch July 1, 2024 02:40

aaronchongth added a commit that referenced this pull request Jul 4, 2024

Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble

1fd22ee

Signed-off-by: Aaron Chong <[email protected]>

aaronchongth added a commit that referenced this pull request Jul 4, 2024

Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Hum…

2e9cb5c

…ble" This reverts commit 1fd22ee.

aaronchongth added a commit that referenced this pull request Jul 4, 2024

Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Hum…

01d68fe

…ble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support jazzy #955

support jazzy #955

koonpeng commented Jun 12, 2024 •

edited

Loading

aaronchongth left a comment

koonpeng commented Jun 26, 2024

koonpeng commented Jun 26, 2024

aaronchongth commented Jun 27, 2024

koonpeng commented Jun 27, 2024 •

edited

Loading

aaronchongth left a comment •

edited

Loading

support jazzy #955

support jazzy #955

Conversation

koonpeng commented Jun 12, 2024 • edited Loading

What's new

Self-checks

Discussion

aaronchongth left a comment

Choose a reason for hiding this comment

koonpeng commented Jun 26, 2024

koonpeng commented Jun 26, 2024

aaronchongth commented Jun 27, 2024

koonpeng commented Jun 27, 2024 • edited Loading

aaronchongth left a comment • edited Loading

Choose a reason for hiding this comment

koonpeng commented Jun 12, 2024 •

edited

Loading

koonpeng commented Jun 27, 2024 •

edited

Loading

aaronchongth left a comment •

edited

Loading