Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 18.19.0, support for Keycloak 23 #857

Merged
merged 62 commits into from
Jan 3, 2024
Merged

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Dec 5, 2023

What's new

This is required for keycloak v23.0.

Migrates to node 18, and all the necessary libraries and dependencies.

Documentation updated to use nvm 18.

Migration to latest done via pnpm,

pnpm i -g pnpm
pnpm up -r -L

TODOs

  • fix react-components, pnpm run build:storybook, which is used in CI
  • fix flaki-ness for puppeteer

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 988 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (2418a3b) 44.08%.
Report is 43 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 171 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 100 Missing ⚠️
...es/api-server/api_server/models/delivery_alerts.py 12.94% 74 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 58 Missing ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 50 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 49 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 48 Missing ⚠️
...ckages/api-server/api_server/repositories/tasks.py 37.31% 42 Missing ⚠️
... and 36 more
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #857      +/-   ##
=================================================
- Coverage          49.35%   44.08%   -5.28%     
=================================================
  Files                285      264      -21     
  Lines               7564     7847     +283     
  Branches            1050     1218     +168     
=================================================
- Hits                3733     3459     -274     
- Misses              3682     4232     +550     
- Partials             149      156       +7     
Flag Coverage Δ
api-server 74.73% <33.22%> (-6.07%) ⬇️
dashboard 14.13% <3.87%> (-0.93%) ⬇️
react-components 36.35% <16.44%> (-11.73%) ⬇️
rmf-auth ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
* Revert all dashboard-e2e packages

Signed-off-by: Aaron Chong <[email protected]>

* Splitting up build:test and start:test for e2e, only retry start:test

Signed-off-by: Aaron Chong <[email protected]>

* Check if build exists to start build again instead

Signed-off-by: Aaron Chong <[email protected]>

* Revert e2e task submission tests to patrol tasks

Signed-off-by: Aaron Chong <[email protected]>

* Remove resolution alerts

Signed-off-by: Aaron Chong <[email protected]>

* Lint

Signed-off-by: Aaron Chong <[email protected]>

* Disabling e2e tests on safari for now, testing on chrome and edge

Signed-off-by: Aaron Chong <[email protected]>

* Running firefox for e2e too

Signed-off-by: Aaron Chong <[email protected]>

* Only testing on Windows 10

Signed-off-by: Aaron Chong <[email protected]>

* Revert commented resolution alert

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth changed the title Node 18.19.0, pnpm i -g pnpm, pnpm up -r -L Node 18.19.0, support for Keycloak 23 Jan 3, 2024
@aaronchongth aaronchongth merged commit 635dfde into deploy/hammer Jan 3, 2024
8 checks passed
@aaronchongth aaronchongth deleted the hammer/bump-node branch January 3, 2024 03:15
@aaronchongth aaronchongth restored the hammer/bump-node branch January 5, 2024 03:03
aaronchongth added a commit that referenced this pull request Jan 5, 2024
aaronchongth added a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant