-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMakeLists: add ppc case to known archs #1816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @barracuda156. This mirrors the current configuration for ppc64, so it seems reasonable to me.
@SWilson4 I just thought we may need to verify one thing. What is the value of I cannot test that immediately, since I have no build environment on 10.5, but let me check with CMake documentation. A fallback would be to use |
@barracuda156 Please let us know when you're ready. Should this be moved to Draft to avoid an unintended merge? |
@barracuda156 This PR is now a bit old and I removed my approval for the time being: Can you please comment (by) when you may have time to move this to completion as discussed above? |
@baentsch Yeah, sorry, will finalize this by this weekend. |
Ok, so yeah, CMake will have the same value for ppc and ppc64 builds on Darwin, since it uses I will rewrite a patch in a way it gonna work correctly now. |
Signed-off-by: Sergey Fedorov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the question, @barracuda156 . I also triggered CI...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the contribution @barracuda156 !
Thanks for merging! |
This is a trivial PR: it simply adds
ppc
to a list of known archs, retaining a warning re no CI for this platform.I have confirmed the build on Darwin ppc for
liboqs
0.10.1 with no other alterations to the code.