Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion with rtmdet-inst, vit, conformer #2453

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Sep 21, 2023

Motivation

  • Fix rtmdet-inst with torchscript
  • Fix vit, conformer on torch2.0

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

None

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage is 31.25% of modified lines.

Files Changed Coverage
.../pytorch/functions/multi_head_attention_forward.py 15.38%
mmdeploy/mmcv/ops/nms.py 100.00%

📢 Thoughts on this report? Let us know!.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon added the bug Something isn't working label Sep 22, 2023
@RunningLeon RunningLeon merged commit 0c21b16 into open-mmlab:main Sep 22, 2023
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants