Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MMEdit to MMagic #2418

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Rename MMEdit to MMagic #2418

merged 1 commit into from
Sep 12, 2023

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Sep 9, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

I only renamed mmedit to mmagic for naming consistency.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
mmdeploy/codebase/mmagic/__init__.py 100.00%
mmdeploy/codebase/mmagic/deploy/__init__.py 100.00%
mmdeploy/codebase/mmagic/deploy/mmagic.py 100.00%
...mdeploy/codebase/mmagic/deploy/super_resolution.py 100.00%

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon added the enhancement New feature or request label Sep 11, 2023
@RunningLeon RunningLeon merged commit 455ec18 into open-mmlab:main Sep 12, 2023
28 of 29 checks passed
@KKIEEK KKIEEK deleted the rename/mmagic branch September 12, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants