-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix urls in CI and readthedocs #2364
Conversation
1a62bcc
to
b97b4f1
Compare
3d3c4ac
to
dd1508d
Compare
c40b10b
to
4c14b5f
Compare
b17c5f8
to
5f68d30
Compare
5f68d30
to
a1752d1
Compare
af0f2e1
to
7b259e5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
==========================================
- Coverage 49.57% 48.31% -1.27%
==========================================
Files 341 350 +9
Lines 13155 13569 +414
Branches 1932 2019 +87
==========================================
+ Hits 6522 6556 +34
- Misses 6170 6566 +396
+ Partials 463 447 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@grimoire @AllentDan hi, any comment on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist