Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix urls in CI and readthedocs #2364

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Conversation

RunningLeon
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon RunningLeon changed the title fix onnx url used in CI [WIP]: fix onnx url used in CI Aug 21, 2023
@RunningLeon RunningLeon added the CI label Aug 23, 2023
@RunningLeon RunningLeon force-pushed the fix_ci_onnx branch 2 times, most recently from 1a62bcc to b97b4f1 Compare August 23, 2023 09:05
@RunningLeon RunningLeon force-pushed the fix_ci_onnx branch 3 times, most recently from c40b10b to 4c14b5f Compare August 28, 2023 07:42
@RunningLeon RunningLeon force-pushed the fix_ci_onnx branch 2 times, most recently from b17c5f8 to 5f68d30 Compare August 28, 2023 08:46
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 54.14% and project coverage change: -1.27% ⚠️

Comparison is base (64e96e3) 49.57% compared to head (0dd0f80) 48.31%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2364      +/-   ##
==========================================
- Coverage   49.57%   48.31%   -1.27%     
==========================================
  Files         341      350       +9     
  Lines       13155    13569     +414     
  Branches     1932     2019      +87     
==========================================
+ Hits         6522     6556      +34     
- Misses       6170     6566     +396     
+ Partials      463      447      -16     
Flag Coverage Δ
unittests 48.31% <54.14%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...oy/codebase/mmdet/models/detectors/single_stage.py 89.28% <ø> (ø)
...eploy/codebase/mmdet/models/detectors/two_stage.py 89.28% <ø> (ø)
...y/codebase/mmdet3d/deploy/voxel_detection_model.py 22.51% <0.00%> (-0.46%) ⬇️
mmdeploy/mmcv/ops/multi_scale_deform_attn.py 75.00% <ø> (ø)
mmdeploy/mmcv/ops/nms_rotated.py 24.69% <0.00%> (ø)
...t/models/detectors/panoptic_two_stage_segmentor.py 22.72% <22.72%> (ø)
...ploy/codebase/mmdet/models/detectors/maskformer.py 29.41% <29.41%> (ø)
...oy/codebase/mmdet/deploy/object_detection_model.py 38.68% <44.08%> (-2.21%) ⬇️
...oy/codebase/mmdet3d/deploy/mono_detection_model.py 49.23% <49.23%> (ø)
...ebase/mmdet/models/seg_heads/base_semantic_head.py 50.00% <50.00%> (ø)
... and 14 more

... and 76 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RunningLeon RunningLeon changed the title [WIP]: fix onnx url used in CI fix urls in CI and readthedocs Aug 29, 2023
@RunningLeon
Copy link
Collaborator Author

@grimoire @AllentDan hi, any comment on this PR?

Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit d9140ab into open-mmlab:main Aug 30, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants