-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mmdeploy.version_info #2215
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2215 +/- ##
==========================================
- Coverage 49.81% 49.61% -0.21%
==========================================
Files 341 341
Lines 13033 13134 +101
Branches 1910 1927 +17
==========================================
+ Hits 6493 6516 +23
- Misses 6089 6158 +69
- Partials 451 460 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@xiabo123 could you fix the lint error by running |
ok |
@RunningLeon Have you encountered the following problems? During Flake8, the version number of mccabe was always incorrect. Both 0.6.0 and 0.6.1 cannot be installed in practice. |
@RunningLeon |
@xiabo123 maybe you could use here to parse the package version. Cause not all packages provide
|
@RunningLeon OK,thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
fix mmdeploy.version_info
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist