[Enhancement] Remove find backend dependencies when build dynamic lib #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May merge the latest main branch to resolve github action errors |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1988 +/- ##
=======================================
Coverage 49.68% 49.68%
=======================================
Files 339 339
Lines 12975 12975
Branches 1899 1899
=======================================
Hits 6447 6447
Misses 6080 6080
Partials 448 448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lvhan028
reviewed
May 22, 2023
| @@ -6,7 +6,7 @@ mmdeploy_add_library(${PROJECT_NAME} opencv_utils.cpp) | |||
|
|
|||
| target_link_libraries(${PROJECT_NAME} | |||
| PRIVATE mmdeploy::core | |||
| PUBLIC ${OpenCV_LIBS}) | |||
| PUBLIC $<BUILD_INTERFACE:${OpenCV_LIBS}>) | |||
There was a problem hiding this comment.
What benefits it can bring in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
support three build strategies:
MMDEPLOY_SHARED_LIBSMMDEPLOY_BUILD_SDK_MONOLITHICmmdeploy lib typeneed find backend packageONOFFdynamicnoOFFOFFstaticyesOFFONdynamicnoModification
Please briefly describe what modification is made in this PR.