Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: smoother notification dark mode (fixes #4424) #4432

Merged
merged 9 commits into from
Sep 24, 2024

Conversation

deeppp15
Copy link
Member

@deeppp15 deeppp15 commented Sep 18, 2024

Description

(fixes #4424)

  • Removed two files which were from previous notification changes
  • We had duplicate row notifications and notification fragment.

Code Changes

  • Removed the old files
  • Used exisiting spineer item instead of default android.

Screenshot

image

xml formatting in fragment_notification
updated spinner_item
@deeppp15 deeppp15 changed the title notification: smoother darkmode elements notification: smoother darkmode elements (fixes #4424) Sep 18, 2024
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all filter is not visible
Screenshot_20240919_145843

@deeppp15
Copy link
Member Author

deeppp15 commented Sep 19, 2024

all filter is not visible Screenshot_20240919_145843

Hi @Okuro3499 ,

Could you try invalidating cache and reviewing again. I dont see it on my end.
@Kuljeet1998 are you also seeing the same UI as Gideon ?

Notification.changes.mp4

@dogi dogi changed the title notification: smoother darkmode elements (fixes #4424) all: smoother notification dark mode (fixes #4424) Sep 19, 2024
@Okuro3499
Copy link
Collaborator

all filter is not visible Screenshot_20240919_145843

Hi @Okuro3499 ,

Could you try invalidating cache and reviewing again. I dont see it on my end. @Kuljeet1998 are you also seeing the same UI as Gideon ?

Notification.changes.mp4

@deeppp15 I still have the issue
nit.webm

@Kuljeet1998
Copy link
Contributor

@deeppp15 Yes, I don't see that either.
image

@deeppp15
Copy link
Member Author

Hi @Okuro3499 @Kuljeet1998

I have tried my changes on multiple devices they are working fine here is an image from another emulator
image
.

  • Make sure you are pulling changes after checking out.

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeppp15 I can now see the filter. make the dropdown button visible in darkmode

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20240924_171502

@dogi dogi merged commit 3cee7b7 into master Sep 24, 2024
2 checks passed
@Okuro3499 Okuro3499 deleted the 4424-notification-darkmode branch October 4, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dashboard: notification back button is not working
4 participants