fonts: initial implementation of locale-specific fonts #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #243
This isn't super critical, as the "browser" rendering is smart enough to use a different font if the glyph is not supported, but using a proper font for that locale looks much nicer.
However, I did not yet add korean/chinese because those font files are massive. I think we'll need to come up with a better strategy where the launcher will download locale-specific font families if that locale is selected. Rather than shipping them with the launcher itself. I'm not doing that right now though (none of the local specific languages even have translations yet), but this atleast sets up everything else around the feature.