feat: add class to loading component #1263 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## opencraft-release/palm.1 #8 +/- ##
===========================================================
Coverage ? 86.98%
===========================================================
Files ? 254
Lines ? 4388
Branches ? 1112
===========================================================
Hits ? 3817
Misses ? 552
Partials ? 19 ☔ View full report in Codecov by Sentry. |
DanielVZ96
force-pushed
the
dvz/page-loading-class
branch
from
611629f
to
b7e6716
Compare
|
@DanielVZ96, we don't need this for now, right? |
|
@Agrendalath right, not needed now thanks to firefox supporting the :has pseudoclass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to modify the height of the loading element for a theme. As the codebase stands it doesn't have any usable selector for this. This PR adds a
page-loadingclass for easy theming.Testing instructions
They can be found in this MR