Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: legacy course navigation #6

Merged

Conversation

ArturGaspar
Copy link
Member

@ArturGaspar ArturGaspar commented Nov 22, 2023

Backports openedx#1239

Description

Add an option to enable the legacy course navigation where clicking a breadcrumb leads to the course index page highlighting the selected section.

Testing instructions

  1. Set ENABLE_LEGACY_NAV='true' and ENABLE_JUMPNAV='false'
  2. Open a course unit
  3. Click the breadcrumb navigation
  4. See that you are redirected to the course index page and that the item corresponding to the selected breadcrumb is highlighted and scrolled to

image
image
image
image

@ArturGaspar ArturGaspar force-pushed the artur/legacy-course-navigation-palm branch 2 times, most recently from f0d4fcd to 5786b5c Compare November 23, 2023 11:00
@ArturGaspar ArturGaspar force-pushed the artur/legacy-course-navigation-palm branch 4 times, most recently from 9ff5e66 to 9a61201 Compare November 27, 2023 07:03
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (opencraft-release/palm.1@0137868). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             opencraft-release/palm.1       #6   +/-   ##
===========================================================
  Coverage                            ?   86.98%           
===========================================================
  Files                               ?      254           
  Lines                               ?     4388           
  Branches                            ?     1112           
===========================================================
  Hits                                ?     3817           
  Misses                              ?      552           
  Partials                            ?       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArturGaspar ArturGaspar force-pushed the artur/legacy-course-navigation-palm branch 2 times, most recently from 3cb39c4 to 79d9cbc Compare November 27, 2023 13:26
Add an option to enable the legacy course navigation where clicking a
breadcrumb leads to the course index page highlighting the selected section.
@ArturGaspar ArturGaspar force-pushed the artur/legacy-course-navigation-palm branch from 79d9cbc to 072e970 Compare December 8, 2023 19:05
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the legacy course navigation works as expected
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a

@Agrendalath Agrendalath merged commit b5e8ae2 into opencraft-release/palm.1 Dec 8, 2023
5 checks passed
@Agrendalath Agrendalath deleted the artur/legacy-course-navigation-palm branch December 8, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants