Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redwood): increase subsection grades rounding precision #34

Conversation

Agrendalath
Copy link
Member

This is a clean backport of openedx#1397.

Private-ref: BB-4210

We used two decimal digits to match the experience from the edx-platform.
However, openedx/edx-platform#27788 increased
the precision to reduce the impact of double rounding.

(cherry picked from commit e4a0105)
@Agrendalath Agrendalath self-assigned this Sep 24, 2024
@Agrendalath Agrendalath changed the title fix: increase subsection grades rounding precision fix(redwood): increase subsection grades rounding precision Sep 24, 2024
@Agrendalath
Copy link
Member Author

Merging as a clean backport.

@Agrendalath Agrendalath merged commit a22759a into opencraft-release/redwood.1 Sep 25, 2024
4 checks passed
@Agrendalath Agrendalath deleted the agrendalath/bb-4210-increase_grading_precision-redwood branch September 25, 2024 14:45
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (opencraft-release/redwood.1@85af65b). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             opencraft-release/redwood.1      #34   +/-   ##
==============================================================
  Coverage                               ?   88.80%           
==============================================================
  Files                                  ?      306           
  Lines                                  ?     5263           
  Branches                               ?     1309           
==============================================================
  Hits                                   ?     4674           
  Misses                                 ?      573           
  Partials                               ?       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant