Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: masquerade dropdown not showing current selection #30

Merged
merged 3 commits into from
Aug 14, 2024
Merged

fix: masquerade dropdown not showing current selection #30

merged 3 commits into from
Aug 14, 2024

Conversation

kaustavb12
Copy link
Member

Description

Cherry-pick from openedx#1434

All details including testing instructions can be found there.

Other information

Private Ref : BB-9074

@kaustavb12 kaustavb12 changed the title Kaustav/fix masquerade dropdown selection eshe fix: masquerade dropdown not showing current selection Aug 13, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.48%. Comparing base (4b4f3fd) to head (ea1a79e).

Files Patch % Lines
...tor-toolbar/masquerade-widget/MasqueradeWidget.jsx 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@                      Coverage Diff                      @@
##           artur/asu-moe/redwood-css      #30      +/-   ##
=============================================================
+ Coverage                      88.77%   89.48%   +0.70%     
=============================================================
  Files                            306      306              
  Lines                           5256     5258       +2     
  Branches                        1333     1302      -31     
=============================================================
+ Hits                            4666     4705      +39     
+ Misses                           573      536      -37     
  Partials                          17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaustavb12 kaustavb12 force-pushed the kaustav/fix_masquerade_dropdown_selection_eshe branch from cae4f3a to ea1a79e Compare August 13, 2024 15:23
viadanna
viadanna approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@viadanna viadanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

  • I tested this on a sandbox.
  • I read through the code.
  • I checked for accessibility issues.

@kaustavb12 kaustavb12 merged commit 702c962 into artur/asu-moe/redwood-css Aug 14, 2024
6 checks passed
@xitij2000 xitij2000 deleted the kaustav/fix_masquerade_dropdown_selection_eshe branch August 14, 2024 14:58
kaustavb12 added a commit that referenced this pull request Sep 2, 2024
@kaustavb12
fix: masquerade dropdown not showing current selection (#30)
3a8c0dd 
* feat: remove child components from state and use data instead

(cherry picked from commit 2d9807e)

* fix: change active selection based on user input

(cherry picked from commit d72eb23)

* test: add test cases

(cherry picked from commit 59d9db5)
(cherry picked from commit 702c962)
@kaustavb12 kaustavb12 mentioned this pull request Sep 2, 2024
Merged
kaustavb12 added a commit that referenced this pull request Sep 2, 2024
@kaustavb12
fix: masquerade dropdown not showing current selection (#30) (#31)
6d98b8b 
* feat: remove child components from state and use data instead

(cherry picked from commit 2d9807e)

* fix: change active selection based on user input

(cherry picked from commit d72eb23)

* test: add test cases

(cherry picked from commit 59d9db5)
(cherry picked from commit 702c962)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viadanna viadanna viadanna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaustavb12 @viadanna