forked from openedx/edx-enterprise
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow enrolling learners on invitation only courses #20
Open
tecoholic
wants to merge
13
commits into
opencraft-release/redwood.1
Choose a base branch
from
tecoholic/BB-8935-redwood-backports
base: opencraft-release/redwood.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: allow enrolling learners on invitation only courses #20
tecoholic
wants to merge
13
commits into
opencraft-release/redwood.1
from
tecoholic/BB-8935-redwood-backports
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new method 'allow_enrollment' to the EnrollmentApiClient that create CourseEnrollmentAllowed flags for learners using their email for specific courses. This method is then called in 2 places: - When subsidy users are bulk processed. For eg., from the enterprise admin portal - When the learners do self-enrollments with a license
Agrendalath
reviewed
Aug 27, 2024
Agrendalath
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a backport QA'd on a Redwood instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ports the changes from the following upstream PRs for Redwood:
Testing Instructions
Setting up the enterprise stack using Tutor
tecoholic/redwood-upgrade
branch of tutor-contrib-enterprisecatalog and install it in your tutor env.enterprise-catalog
entry.bb8935-fixes.py
That should get everything up and running.
Adding Enterprise Data
LMS
seed_enterprise_devstack_data
.Course Discovery
./manage.py refresh_course_metadata
to pull all the data.update_index --disable-change-limit
to update the index.owners
, and thecourse_run > seats
fields are populated by visiting http://discovery.local.edly.io:8381/api/v1/courses/Enterprise Catalog
./manage.py lms migrate_enterprise_catalogs --api_user enterprise_catalog_worker
. If it fails, replaceenterprise_catalog_worker
with your admin username. I didn't find the time to debug this bug yet.courseruns
update_content_metadata --force
andreindex_algolia --force
.License Manager
Get their LMS numerical ID from the LMS admin.
Testing the PR Changes
Note: this requires acting as 2 users simultaneously. Use private mode or 2 profiles or Firefox containers.
Normal Flow
test-enterprise_learner_1
with passwordedx
. The Learner Dashboard should show the following message.http://apps.local.edly.io:8734/test-enterprise
, change this URL tohttp://apps.local.edly.io:8734/learner-portal-enterprise/test-enterprise
.Invite only course
true
and save.test-enterprise_learner_2
. The enrollment should fail and an error message shown in the enterprise learner portal.