-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update autolink version for Mattermost (do not merge) #135
base: master
Are you sure you want to change the base?
Conversation
MATTERMOST_UNLINK_VERSION: 0.3.0 | ||
# UNLINK is the autolink plugin which converts JIRA tickets to clickable URL | ||
# https://github.com/mattermost/mattermost-plugin-autolink/releases/ | ||
MATTERMOST_UNLINK_VERSION: 1.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SSPJ, the latest version is 1.1.0
and I installed that version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lgp171188 Right, this PR isn't for merging; I just pushed it so that you would have something to look at. I should have made that clear in the description, sorry!
- name: generate autolink configuration | ||
template: | ||
src: autolink.json.j2 | ||
dest: "{{ MATTERMOST_CONFIG_FILE|dirname }}/autolink.json" | ||
dest: "{{ MATTERMOST_STATUS_DIR }}/autolink.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SSPJ, this wasn't needed when I did the upgrade and the auto-linking works okay. So is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's just reducing some code complexity: MATTERMOST_CONFIG_FILE
is "{{ MATTERMOST_STATUS_DIR }}/config.json"
and so MATTERMOST_CONFIG_FILE|dirname
is just MATTERMOST_STATUS_DIR
.
@@ -8,10 +8,6 @@ | |||
{ | |||
"Pattern": "(?P<project>{{ project }})-(?P<id>\\d{1,6})(?P<comma>[,;]*)", | |||
"Template": "[${project}-${id}](https://{{ domain.domain }}/browse/${project}-${id})${comma}" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SSPJ, I didn't see any issues with this pattern. Is there a reason for removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember why I took it out, sorry.
No description provided.