feat(condo): DOMA-10226 add full stacked gql error traces #5243

pahaz · 2024-09-16T12:43:21Z

Improve developer experience. And show what the real original error. And provide a full stack trace with internal and intermediate errors.

    GQLError: [error] Create Meter internal error
        at _throwIfError (~/packages/codegen/generate.server.utils.js:67:15)
        at _throwIfError (~/packages/codegen/generate.server.utils.js:140:5)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at Object.create (~/packages/codegen/generate.server.utils.js:213:16)
        at resolver (~/apps/condo/domains/meter/schema/RegisterMetersReadingsService.js:397:50)
    ^- Caused By: Error: Unable to connect a Meter.resource<MeterResource>
        at ~/node_modules/@keystonejs/keystone/lib/ListTypes/utils.js:44:23
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at List._resolveRelationship (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:617:35)
        at ~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:741:26
        at List._nestedMutation (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:683:35)
        at List._createSingle (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:733:12)
        at List.createMutation (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:713:12)
        at List.createMutation (~/packages/keystone/requestCache.js:151:16)
        at execGqlWithoutAccess (~/packages/codegen/generate.server.utils.js:131:30)
        at Object.create (~/packages/codegen/generate.server.utils.js:213:16)
        at resolver (~/apps/condo/domains/meter/schema/RegisterMetersReadingsService.js:397:50)
    ^- Caused By: Error: Unable to connect a Meter.resource<MeterResource>
        at throwWithErrors (~/node_modules/@keystonejs/fields/dist/fields.cjs.dev.js:1949:17)
        at resolveNestedSingle (~/node_modules/@keystonejs/fields/dist/fields.cjs.dev.js:2183:7)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at resolveNested (~/node_modules/@keystonejs/fields/dist/fields.cjs.dev.js:2230:10)
        at Relationship.resolveNestedOperations (~/node_modules/@keystonejs/fields/dist/fields.cjs.dev.js:2475:9)
        at ~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:620:61
        at Object.pReflect [as default] (~/node_modules/p-reflect/index.js:5:17)
        at async Promise.all (index 3)
        at resolveAllKeys (~/node_modules/@keystonejs/utils/dist/utils.cjs.dev.js:42:19)
        at List._resolveRelationship (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:617:35)
        at ~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:741:26
        at List._nestedMutation (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:683:35)
        at List._createSingle (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:733:12)
        at List.createMutation (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:713:12)
        at List.createMutation (~/packages/keystone/requestCache.js:151:16)
        at execGqlWithoutAccess (~/packages/codegen/generate.server.utils.js:131:30)
        at Object.create (~/packages/codegen/generate.server.utils.js:213:16)
        at resolver (~/apps/condo/domains/meter/schema/RegisterMetersReadingsService.js:397:50)
    ^- Caused By: AccessDeniedError: You do not have access to this resource
        at throwAccessDenied (~/node_modules/@keystonejs/keystone/lib/ListTypes/graphqlErrors.js:17:9)
        at _throwAccessDenied (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:387:7)
        at List.getAccessControlledItem (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:422:7)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at List.itemQuery (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:527:20)
        at List.itemQuery (~/packages/keystone/requestCache.js:196:16)
        at resolveNestedSingle (~/node_modules/@keystonejs/fields/dist/fields.cjs.dev.js:2179:14)
        at resolveNested (~/node_modules/@keystonejs/fields/dist/fields.cjs.dev.js:2230:10)
        at Relationship.resolveNestedOperations (~/node_modules/@keystonejs/fields/dist/fields.cjs.dev.js:2475:9)
        at ~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:620:61
        at Object.pReflect [as default] (~/node_modules/p-reflect/index.js:5:17)
        at async Promise.all (index 3)
        at resolveAllKeys (~/node_modules/@keystonejs/utils/dist/utils.cjs.dev.js:42:19)
        at List._resolveRelationship (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:617:35)
        at ~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:741:26
        at List._nestedMutation (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:683:35)
        at List._createSingle (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:733:12)
        at List.createMutation (~/node_modules/@keystonejs/keystone/lib/ListTypes/list.js:713:12)
        at List.createMutation (~/packages/keystone/requestCache.js:151:16)
        at execGqlWithoutAccess (~/packages/codegen/generate.server.utils.js:131:30)
        at Object.create (~/packages/codegen/generate.server.utils.js:213:16)
        at resolver (~/apps/condo/domains/meter/schema/RegisterMetersReadingsService.js:397:50)

…tests

…full trace to developer in case of jest error

…rror context

packages/keystone/apolloErrorFormatter.js

packages/keystone/test.utils.js

…GQLError for schema docs

packages/keystone/preprocessors/schemaDoc.js

…or: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

…kward compatibility

SavelevMatthew · 2024-10-03T12:02:36Z

Can you explain translations part a bit? Should I add some keys on per-app basis? What's the en.json in KS is used for? Only tests? Because I (probably) don't want to merge KS translations with app ones 🤔

pahaz · 2024-10-03T14:32:01Z

Can you explain translations part a bit? Should I add some keys on per-app basis? What's the en.json in KS is used for? Only tests? Because I (probably) don't want to merge KS translations with app ones 🤔

Yes, unfortunately, it's just for tests. It's because of const { getTranslations } = require('@open-condo/locales/loader')

I've dropped it and mocked the @open-condo/locales/loader function because it's a spec.js

sonarcloud · 2024-10-03T16:43:42Z

Quality Gate passed

Issues
25 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

refactor(condo): DOMA-10227 remove ensure-error

5c3a0bf

pahaz temporarily deployed to internal September 16, 2024 12:43 — with GitHub Actions Inactive

refactor(condo): DOMA-10232 cleanup apolloErrorFormatter

b612423

pahaz temporarily deployed to internal September 17, 2024 05:39 — with GitHub Actions Inactive

fix(condo): DOMA-10227 remove apollo-server-errors

e87a6a4

pahaz temporarily deployed to internal September 17, 2024 05:44 — with GitHub Actions Inactive

fix(condo): DOMA-10227 apolloError style and tests

232be31

pahaz temporarily deployed to internal September 17, 2024 05:53 — with GitHub Actions Inactive

pahaz temporarily deployed to internal September 17, 2024 06:32 — with GitHub Actions Inactive

pahaz temporarily deployed to internal September 17, 2024 06:45 — with GitHub Actions Inactive

pahaz added 9 commits September 18, 2024 16:57

feat(condo): DOMA-10226 add fullstack

0f7ba06

feat(condo): DOMA-10226 add nested error throw

b418ee9

refactor(condo): DOMA-10226 hide internal and development fields for …

e8239f5

…tests

refactor(condo): DOMA-10226 catchErrorFrom, we want to display error …

bb02acf

…full trace to developer in case of jest error

refactor(condo): DOMA-10226 refactor catchErrorFrom

27c57ff

refactor(condo): DOMA-10226 refactor validateQRCodeByTestClient add e…

2a46416

…rror context

refactor(condo): DOMA-10226 improve readability

7a131cf

refactor(condo): DOMA-10226 improve readability and fix mistakes

85e06b2

refactor(condo): DOMA-10226 add todo

7fa02de

pahaz temporarily deployed to internal September 20, 2024 21:02 — with GitHub Actions Inactive

pahaz changed the title ~~refactor(condo): DOMA-10227 remove ensure-error~~ feat(condo): DOMA-10226 add full stacked gql error traces Sep 20, 2024

pahaz commented Sep 20, 2024

View reviewed changes

packages/keystone/apolloErrorFormatter.js Outdated Show resolved Hide resolved

pahaz commented Sep 20, 2024

View reviewed changes

packages/keystone/test.utils.js Outdated Show resolved Hide resolved

pahaz marked this pull request as draft September 20, 2024 21:31

Merge branch 'main' into errors-gql

d6636dd

pahaz temporarily deployed to internal September 23, 2024 09:03 — with GitHub Actions Inactive

pahaz added 4 commits September 24, 2024 11:53

fix(condo): DOMA-10226 process exit 1 if any error

8f7a004

chore(condo): DOMA-10226 rollback changes

e9857ca

refactor(condo): DOMA-10226 cleanup the logic and style

3f415dc

refactor(condo): DOMA-10232 add default messageInterpolation and use …

44f0469

…GQLError for schema docs

pahaz added 2 commits October 1, 2024 17:33

fix(condo): DOMA-10226 add data backward compatibility field

a01992a

fix(condo): DOMA-10226 add some missed messages

dcd0a08

pahaz temporarily deployed to internal October 1, 2024 14:34 — with GitHub Actions Inactive

fix(condo): DOMA-10226 add CI diff

be4e122

pahaz temporarily deployed to internal October 1, 2024 17:30 — with GitHub Actions Inactive

YEgorLu mentioned this pull request Oct 1, 2024

fix(global): DOMA-10345 format eror translations #5305

Merged

Alllex202 reviewed Oct 1, 2024

View reviewed changes

packages/keystone/preprocessors/schemaDoc.js Show resolved Hide resolved

Alllex202 approved these changes Oct 1, 2024

View reviewed changes

pahaz added 2 commits October 1, 2024 22:39

fix(condo): DOMA-10226 change DEFAULT_LOCALE to en

5ce1139

fix(condo): DOMA-10226 fix CreateArtifact: Received non-retryable err…

b2bed91

…or: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

pahaz temporarily deployed to internal October 1, 2024 19:39 — with GitHub Actions Inactive

fix(condo): DOMA-10226 some tests

d18b334

pahaz temporarily deployed to internal October 1, 2024 20:38 — with GitHub Actions Inactive

pahaz added 4 commits October 2, 2024 12:53

fix(condo): DOMA-10226 add .errors extraction and .data field for bac…

ae80ced

…kward compatibility

refactor(condo): DOMA-10226 some error checks

5dddc1d

fix(condo): DOMA-10370 add sendMessageToSupport docs

060dd1b

chore(condo): DOMA-10370 fix docs text

d2e4f41

dkoviazin approved these changes Oct 3, 2024

View reviewed changes

pahaz added 2 commits October 3, 2024 14:39

chore(condo): DOMA-10226 improve compatibility and DX

1d0a68f

chore(condo): DOMA-10226 improve tooling and DX

792b79c

pahaz added 3 commits October 3, 2024 17:36

chore(condo): DOMA-10226 use mock for @open-condo/locales/loader

6b1c27c

chore(condo): DOMA-10226 add backward compatibility

ab575ff

chore(condo): DOMA-10368 change some tests compatibility

bb63f54

pahaz temporarily deployed to internal October 3, 2024 15:40 — with GitHub Actions Inactive

chore(condo): DOMA-10232 ci fixes

5e9c119

pahaz temporarily deployed to internal October 3, 2024 16:37 — with GitHub Actions Inactive

pahaz mentioned this pull request Oct 3, 2024

feat(global): DOMA-10386 add script to test translations #5314

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(condo): DOMA-10226 add full stacked gql error traces #5243

feat(condo): DOMA-10226 add full stacked gql error traces #5243

pahaz commented Sep 16, 2024 •

edited

Loading

SavelevMatthew commented Oct 3, 2024

pahaz commented Oct 3, 2024 •

edited

Loading

sonarcloud bot commented Oct 3, 2024

feat(condo): DOMA-10226 add full stacked gql error traces #5243

Are you sure you want to change the base?

feat(condo): DOMA-10226 add full stacked gql error traces #5243

Conversation

pahaz commented Sep 16, 2024 • edited Loading

SavelevMatthew commented Oct 3, 2024

pahaz commented Oct 3, 2024 • edited Loading

sonarcloud bot commented Oct 3, 2024

Quality Gate passed

pahaz commented Sep 16, 2024 •

edited

Loading

pahaz commented Oct 3, 2024 •

edited

Loading