Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): INFRA-509 migrate from CSF2 to CSF3. Fixed storybook #5234

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

Alllex202
Copy link
Contributor

@Alllex202 Alllex202 commented Sep 12, 2024

  • fixed display of components in storybook
  • migrate from CSF2 to CSF3

@Alllex202 Alllex202 added ✋🙂 Review please Comments are resolved, take a look, please 📦 Packages labels Sep 12, 2024
@Alllex202 Alllex202 changed the title feat(condo): INFRA-509 migrate from CSF2 to CSF3. Fixed storybook feat(ui): INFRA-509 migrate from CSF2 to CSF3. Fixed storybook Sep 12, 2024
accent: boolean;
disabled: boolean;
headerTag: boolean;
header: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;?

Why it's not linted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added rule in eslint

Copy link
Member

@SavelevMatthew SavelevMatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run eslint --fix to fix commas, overall looks legit

Copy link

sonarcloud bot commented Sep 13, 2024

@Alllex202 Alllex202 merged commit 0a3a390 into main Sep 13, 2024
26 checks passed
@Alllex202 Alllex202 deleted the feat/ui/INFRA-509/fix-storybook branch September 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Packages ✋🙂 Review please Comments are resolved, take a look, please
Development

Successfully merging this pull request may close these issues.

3 participants