New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(condo): DOMA-10042 handler for suggesting providers #5163

Merged

YEgorLu merged 10 commits into main from feat/condo/DOMA-10042/suggest-providers

Sep 5, 2024

Contributor

YEgorLu commented Sep 2, 2024

Added handler for suggesting providers by tin or name

YEgorLu temporarily deployed to internal

September 2, 2024 14:01

— with

GitHub Actions Inactive

dkoviazin added the ✋🙂 Review please label

dkoviazin reviewed

View reviewed changes

Contributor

dkoviazin left a comment

You need to use Service Provider instead of provider

pahaz reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

pahaz reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

pahaz reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/billing/utils/testSchema/mixins/organization.js Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/constants/constants.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/constants/constants.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/gql.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.test.js Show resolved Hide resolved

SavelevMatthew requested changes

View reviewed changes

Member

SavelevMatthew left a comment

Overall looks OK, got some code-style issues, which can be easily resolved...

But I've also got some serious issues, like:

Ordering logic
Redis keys naming convention
TIN duplicates display
Server utils usage

So I cannot pass it for now, but code itself is fine

YEgorLu removed the ✋🙂 Review please label

YEgorLu force-pushed the feat/condo/DOMA-10042/suggest-providers branch from eba67bd to e5a050a Compare

September 3, 2024 12:48

YEgorLu temporarily deployed to internal

September 3, 2024 12:48

— with

GitHub Actions Inactive

YEgorLu and others added 8 commits

September 4, 2024 15:51


          feat(condo): DOMA-10042 add query/resolver for searching service prov…

ceacd57

…iders by tin


          feat(condo): DOMA-10042 added tests

f3e2e7c


          feat(condo): DOMA-10042 moved suggestServiceProviders to resident domain

55ba10a


          feat(condo): DOMA-10042 added search by provider name

e16b551


          feat(condo): DOMA-10042 rename suggestServiceProviderService

bbeda18


          style(condo): DOMA-10042 renamed providers to serviceProviders

f141774


          fix(condo): DOMA-10042 removed serverUtils and db-side sorting; searc…

7c791c5

…hing name case-insensitive


          refactor(condo): DOMA-10042 simplified test for duplicate tins, made …

083e49a

…more grouping for tests


          fix(condo): DOMA-10042 added limit to organizations query, removed so…

569db8d

…rting

YEgorLu force-pushed the feat/condo/DOMA-10042/suggest-providers branch from e5a050a to 569db8d Compare

September 4, 2024 10:52

YEgorLu temporarily deployed to internal

September 4, 2024 10:52

— with

GitHub Actions Inactive

SavelevMatthew approved these changes

View reviewed changes

YEgorLu added the ✋🙂 Review please label

SavelevMatthew requested changes

View reviewed changes

Member

SavelevMatthew left a comment

Redis Keys must be changed

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.js Outdated Show resolved Hide resolved


          fix(condo): DOMA-10042 rename redisGuard key name

abd3cc5

YEgorLu temporarily deployed to internal

September 4, 2024 11:46

— with

GitHub Actions Inactive

sonarcloud bot commented Sep 4, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

SavelevMatthew approved these changes

View reviewed changes

dkoviazin approved these changes

View reviewed changes

apps/condo/domains/resident/schema/SuggestServiceProviderService.test.js Show resolved Hide resolved

apps/condo/domains/resident/schema/SuggestServiceProviderService.test.js Show resolved Hide resolved

YEgorLu temporarily deployed to internal

September 5, 2024 05:24

— with

GitHub Actions Inactive

YEgorLu temporarily deployed to internal

September 5, 2024 07:03

— with

GitHub Actions Inactive

YEgorLu temporarily deployed to internal

September 5, 2024 12:11

— with

GitHub Actions Inactive

YEgorLu temporarily deployed to internal

September 5, 2024 12:54

— with

GitHub Actions Inactive

YEgorLu temporarily deployed to internal

September 5, 2024 14:08

— with

GitHub Actions Inactive

YEgorLu removed the ✋🙂 Review please label

YEgorLu merged commit ef95038 into main

26 checks passed

YEgorLu deleted the feat/condo/DOMA-10042/suggest-providers branch

September 5, 2024 15:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet