hotfix(ui): DOMA-8998 fixed radio group with button type (#4721)

* hotfix(ui): DOMA-8998 fixed radio group with button type * hotfix(ui): DOMA-8998 fixed mixin call
open-condo-software · May 14, 2024 · aa02e32 · aa02e32
1 parent 5c1d38d
commit aa02e32
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/packages/ui/src/components/Button/icon/style.less b/packages/ui/src/components/Button/icon/style.less
@@ -19,7 +19,7 @@
   background-color: transparent;
   border: none;
   border-radius: @condo-icon-button-border-radius-medium;
-  .condo-transition(background);
+  .condo-transition(background;);
 
   span {
     position: relative;
@@ -42,18 +42,18 @@
 
     background: @condo-global-color-brand-gradient-1;
     opacity: 0;
-    .condo-transition(opacity);
+    .condo-transition(opacity;);
   }
 
   .condo-icon-btn-content {
     display: inline-flex;
     color: @condo-global-color-black;
-    .condo-transition(color);
+    .condo-transition(color;);
 
     svg {
       color: @condo-global-color-black;
       fill: currentcolor;
-      .condo-transition(color);
+      .condo-transition(color;);
     }
   }
 

diff --git a/packages/ui/src/components/Checkbox/style.less b/packages/ui/src/components/Checkbox/style.less
@@ -24,14 +24,14 @@
     top: 0;
     border-color: @condo-global-color-gray-5;
 
-    .condo-transition(border-color);
+    .condo-transition(border-color;);
 
     &-inner {
       box-sizing: content-box;
       border-color: @condo-global-color-gray-5;
       outline: none;
 
-      .condo-transition(border-color, opacity);
+      .condo-transition(border-color, opacity;);
 
       // Before layer is used to show gradient outline on tab-focusing
       &::before {

diff --git a/packages/ui/src/components/Typography/style.less b/packages/ui/src/components/Typography/style.less
@@ -6,7 +6,7 @@
 
 .condo-typography {
   @condo-typography-decoration-thickness: 1px;
-  .condo-transition(color, opacity, text-decoration-color);
+  .condo-transition(color, opacity, text-decoration-color;);
 
   word-break: break-word;
 

diff --git a/packages/ui/src/components/style/mixins/transition.less b/packages/ui/src/components/style/mixins/transition.less
@@ -1,5 +1,7 @@
+// NOTE: The semicolon in the mixin call ".condo-transition(color, opacity;);" is very important.
+// If it is omitted, the comma between the two parameters will be deleted which ends up in an invalid css rule.
 .condo-transition(@transition-property...) {
   transition-timing-function: ease-in;
   transition-duration: @condo-global-transition-duration-default;
   transition-property: @transition-property;
-}
+}