Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate lmdeploy pipeline api #1198

Merged
merged 20 commits into from
Oct 9, 2024

Conversation

lvhan028
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

configs/models/hf_internlm/lmdeploy_internlm2_chat_7b.py Outdated Show resolved Hide resolved
batch_size=32768,
# the max number of prompts that LMDeploy receives
# in `generate` function
batch_size=5000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bs exceeds the max QPS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default max_batch_size of lmdeploy engines is 256 on A100
batch_size as far as I know is the length of messages passed to the generate in TurboMindModelwithChatTemplate.
The greater batch_size is, the higher throughput lmdeploy inference engine can achieve.

docs/zh_cn/advanced_guides/evaluation_lmdeploy.md Outdated Show resolved Hide resolved
configs/models/hf_internlm/lmdeploy_internlm2_chat_7b.py Outdated Show resolved Hide resolved
@lvhan028
Copy link
Contributor Author

It was found that the accuracy degraded compared to the engine integration.
I am debugging it and will let you know once it is ready

Copy link
Collaborator

@zhulinJulia24 zhulinJulia24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhulinJulia24
Copy link
Collaborator

use newest lmdeploy code with opencompass main and this pr to do evaluation (batch_size = 1):
main code: https://github.com/InternLM/lmdeploy/actions/runs/11251926631
pr code: https://github.com/InternLM/lmdeploy/actions/runs/11252037673
there scores are different.

use vimdiff to compass predictions. Is that expected? @lvhan028
image

@lvhan028
Copy link
Contributor Author

lvhan028 commented Oct 9, 2024

@zhulinJulia24 in main branch, BOS token is missed when tokenizing the message.

input_ids = self.tokenizer.encode(prompt, add_bos=False)

In this PR, BOS token is added.
That's the reason

@lvhan028 lvhan028 requested a review from tonysy October 9, 2024 11:29
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonysy tonysy merged commit b52ba65 into open-compass:main Oct 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants