-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate lmdeploy pipeline api #1198
Integrate lmdeploy pipeline api #1198
Conversation
batch_size=32768, | ||
# the max number of prompts that LMDeploy receives | ||
# in `generate` function | ||
batch_size=5000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bs exceeds the max QPS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default max_batch_size
of lmdeploy engines is 256 on A100
batch_size
as far as I know is the length of messages
passed to the generate
in TurboMindModelwithChatTemplate
.
The greater batch_size
is, the higher throughput lmdeploy inference engine can achieve.
It was found that the accuracy degraded compared to the engine integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
use newest lmdeploy code with opencompass main and this pr to do evaluation (batch_size = 1): use vimdiff to compass predictions. Is that expected? @lvhan028 |
@zhulinJulia24 in main branch, BOS token is missed when tokenizing the message.
In this PR, BOS token is added. That's the reason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: