use requests with attested connection pooling #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:
MegaLinter is graciously provided by |
HernanGatta
force-pushed
the
hegatta/connection-pooling
branch
from
2ec487c
to
b7b231c
Compare
ggroode
approved these changes
Aug 28, 2023
octaviansima
approved these changes
Aug 29, 2023
| from promptguard.authentication import get_api_key | ||
| from promptguard.configuration import get_server_config | ||
|
|
||
| _session: Optional[requests.Session] = None | ||
| _sessionLock: threading.Lock = threading.Lock() |
There was a problem hiding this comment.
Nit: _session_lock to match Python naming convention
Some comments about what these variables are used for would also help
zizhong
reviewed
Aug 29, 2023
| api_key = get_api_key() | ||
| hostname, port = get_server_config() | ||
|
|
||
| ctx = AttestedTLSContext(_get_default_validators()) | ||
| conn = AttestedHTTPSConnection(hostname, ctx, port) | ||
| response = _session.request( |
There was a problem hiding this comment.
This code doesn't handle the case where connection was closed (maybe by remote). Possibly need something like https://github.com/singer-io/tap-skubana/pull/6/files or better.
HernanGatta
force-pushed
the
hegatta/connection-pooling
branch
from
fb152f4
to
16db125
Compare
HernanGatta
force-pushed
the
hegatta/connection-pooling
branch
from
16db125
to
25a2b97
Compare
octaviansima
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the PromptGuard client to use the changes proposed to the underlying aTLS package. Namely, this PR modifies the PromptGuard client to use the
requestslibrary and to utilize the aTLS adapter in the aforementioned PR to in turn gain support for connection pooling, thereby greatly reducing the per-request latency.