-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mark signal v0.2.4 as failed #831
Merged
Merged
Commits on Mar 22, 2024
-
fix: mark signal v0.2.4 as failed
The ooni/probe-cli#1421 PR trimmed the endpoints and bumped signal's version to v0.2.5. So we need to ignore versions of signal lower than v0.2.5. I am wondering whether we should also use a time window because otherwise what happens when we reprocess measurements. If my analysis is correct, then we have an additional issue that there's another check in this codepath that seems to mark signal measurements as failed without any temporal constraints. This would also cause reprocessing to cause downstream issues. Part of ooni/probe#2636
Configuration menu - View commit details
-
Copy full SHA for 5399ffe - Browse repository at this point
Copy the full SHA 5399ffeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c09df46 - Browse repository at this point
Copy the full SHA c09df46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1542504 - Browse repository at this point
Copy the full SHA 1542504View commit details -
I discussed this with @hellais and he said I should not be spending too much time in thinking about reprocessing and recommended to use queries to modify the database. So, I'll change the todo into a caveat.
Configuration menu - View commit details
-
Copy full SHA for 1de4276 - Browse repository at this point
Copy the full SHA 1de4276View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2dd123d - Browse repository at this point
Copy the full SHA 2dd123dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08dcc01 - Browse repository at this point
Copy the full SHA 08dcc01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8720af8 - Browse repository at this point
Copy the full SHA 8720af8View commit details -
Do strict check on version number
Fix changelog entry to avoid conflict with: https://github.com/ooni/backend/pull/793/files
Configuration menu - View commit details
-
Copy full SHA for ff33685 - Browse repository at this point
Copy the full SHA ff33685View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.