Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark signal v0.2.4 as failed #831

Merged
merged 8 commits into from
Mar 25, 2024
Merged

fix: mark signal v0.2.4 as failed #831

merged 8 commits into from
Mar 25, 2024

Commits on Mar 22, 2024

  1. fix: mark signal v0.2.4 as failed

    The ooni/probe-cli#1421 PR trimmed the endpoints and bumped signal's version to v0.2.5.
    
    So we need to ignore versions of signal lower than v0.2.5.
    
    I am wondering whether we should also use a time window because otherwise what happens when we reprocess measurements. If my analysis is correct, then we have an additional issue that there's another check in this codepath that seems to mark signal measurements as failed without any temporal constraints. This would also cause reprocessing to cause downstream issues.
    
    Part of ooni/probe#2636
    bassosimone authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    5399ffe View commit details
    Browse the repository at this point in the history
  2. x

    bassosimone authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c09df46 View commit details
    Browse the repository at this point in the history
  3. x

    bassosimone authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1542504 View commit details
    Browse the repository at this point in the history
  4. x

    I discussed this with @hellais and he said I should not be spending too much time in thinking about reprocessing and recommended to use queries to modify the database.
    
    So, I'll change the todo into a caveat.
    bassosimone authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1de4276 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    2dd123d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08dcc01 View commit details
    Browse the repository at this point in the history
  3. Bump changelog entry

    hellais committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    8720af8 View commit details
    Browse the repository at this point in the history
  4. Do strict check on version number

    Fix changelog entry to avoid conflict with: https://github.com/ooni/backend/pull/793/files
    hellais committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ff33685 View commit details
    Browse the repository at this point in the history