Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed InitialFolder so it now works more than first time its called p… …r. application #1

Closed
wants to merge 2 commits into from

Conversation

buildcomplete
Copy link

The dialog.SetDefaultFolder(item) is only set first time the applications sets the folder,
Next time the folder will be restored to last picked object and the 'Default folder' is ignored
Use instead dialog.SetFolder which behaviour better matches the name 'InitialFolder'

…r. application

The dialog.SetDefaultFolder(item) is only set first time the applications sets the folder,
Next time the folder will be restored to last picked object and the 'Default folder' is ignored
Use instead dialog.SetFolder which behaviour better matches the name 'InitialFolder'
…irectory

Fixed InitialFolder so it now works more than first time its called p…
@augustoproiete augustoproiete self-assigned this Apr 9, 2019
@augustoproiete augustoproiete added the bug Something isn't working label Apr 10, 2019
@augustoproiete
Copy link
Member

augustoproiete commented Apr 10, 2019

Thank you @buildcomplete!

Could you please update the pull-request to come from your branch buildcomplete-patch-nitial-directory instead of your branch master?

@augustoproiete augustoproiete removed the bug Something isn't working label Apr 10, 2019
@augustoproiete
Copy link
Member

@buildcomplete I'm not convinced this is a bug. This seems to be a common behavior in several applications... Visual Studio, Notepad, Excel, ... Basically the first time you open the dialog, it points you to the default folder you set. If you switch to different folder than the default one, it remembers what that folder is (in case you want to open more files from that folder, for example).

What are your thoughts?

@buildcomplete
Copy link
Author

I couldn't change the source in this pull, so I made a new comming from the branch as you mention. #2

@augustoproiete
Copy link
Member

Thanks. Will close this one then, and we can continue the discussion on #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants