Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-818 upgrade to RDF4J 5.0.2 #819

Open
wants to merge 5 commits into
base: version5
Choose a base branch
from

Conversation

hmottestad
Copy link

@hmottestad hmottestad commented Jul 31, 2024

Fixes #818

Upgrade from RDF4J 4.3.10 to RDF4J 5.0.2.

@hmottestad
Copy link
Author

hmottestad commented Aug 1, 2024

OWLAPI has been updated to RDF4J 5. We need to wait for it to be released.

See: owlcs/owlapi#1146

@hmottestad
Copy link
Author

@bcogrel @ghxiao

What are your thoughts on upgrading to RDF4J 5.0.1?

@reckart and I have managed to upgrade OWLAPI and once @ignazio1977 releases the upgrade then this PR here should be ready.

@bcogrel
Copy link
Member

bcogrel commented Aug 13, 2024

Thanks @hmottestad for this PR!

To me, it makes sense doing such upgrade once the new version of OWLAPI is out.
In the meantime, is the snapshot version of OWLAPI 5.5.1 published somewhere, so as to have the pipeline running?

@hmottestad
Copy link
Author

hmottestad commented Aug 14, 2024

I'm not aware of any snapshot maven repo for OWLAPI. Do you know if the snapshot builds of OWLAPI are published anywhere @ignazio1977 ?

@hmottestad hmottestad changed the title GH-818 upgrade to RDF4J 5.0.1 GH-818 upgrade to RDF4J 5.0.2 Aug 14, 2024
@ignazio1977
Copy link

owlapi snapshots builds

They can be published via Sonatype but that doesn't happen very often. If I remember correctly snapshots are deleted after a few days.

It would be a manual process either way.

@bcogrel
Copy link
Member

bcogrel commented Aug 14, 2024

Thanks for the info. I was just asking in case the snapshots were already available so we can already test.

I don't think it is worth the effort, so I suggest just waiting for a new release of OWLAPI.

@hmottestad
Copy link
Author

owlapi snapshots builds

They can be published via Sonatype but that doesn't happen very often. If I remember correctly snapshots are deleted after a few days.

It would be a manual process either way.

RDF4J has a nightly snapshot build that is published to the oss sonatype snapshots repo: https://github.com/eclipse-rdf4j/rdf4j/blob/eab72726d7814fe73476f78477adf27e4ff67155/pom.xml#L57

Not that you need to set up anything similar. Just to show how we've solved it. I don't think it's used very often though.

@ignazio1977
Copy link

Owlapi used to have a travis job that could have included deploying snapshots, but travis stopped offering free builds a while ago and we don't have any funding to tap into :-) so it fell by the wayside. Not much activity on the owlapi repositories either, these days.

@reckart
Copy link

reckart commented Aug 14, 2024

GitHub actions are very easy to set up and are free for OSS projects.

Basically, go to the actions tab, click on the maven build action to add it - and then possibly comment out the dependency analysis part from the action script because (in my experience) that tends to fail. Then you have PR builds already and can add more stuff like snapshot deployment or artifact caching if required.

@hmottestad
Copy link
Author

RDF4J is lucky to be part of the Eclipse organisation. Someone at Eclipse is in charge of maintaining several Jenkins environments and we get to use one for free. And when there is downtime we can post an issue in their Gitlab and it's up an running the next day :)

The integration between GitHub and Jenkins was never that great and we only use Jenkins for nightly snapshot builds and when we publish a new release of RDF4J. For anything related to build stability, tests and PRs we use GitHub Actions, which is free :D Though you never know when Microsoft will be happy with their market share and start charging for that too :P

@hmottestad
Copy link
Author

@ignazio1977 Do you have a plan when you will be releasing the next OWLAPI version?

@ignazio1977
Copy link

@hmottestad I'll add in the bom and release, I think. I'll have a quick check for library updates as well. In terms of deadlines, perhaps a couple of weeks.

@ignazio1977
Copy link

@hmottestad version 5.5.1 just released

@hmottestad hmottestad marked this pull request as ready for review September 8, 2024 08:25
@hmottestad
Copy link
Author

Thank you @ignazio1977 !

@bcogrel Would you like to take a look and run the tests?

@bcogrel
Copy link
Member

bcogrel commented Sep 8, 2024

Thanks for releasing OWLAPI and for updating the branch! Tests are passing.

We need to understand to which version attaching these changes, as we released 5.2.0 a few weeks ago.
Let us discuss it within the Ontop team next week.

@bcogrel
Copy link
Member

bcogrel commented Sep 10, 2024

Our plan is to release it soon as 5.3.0. We need first to test the Ontop Protégé plugin, as the co-existence of two versions of OWLAPI (4 and 5) there is a bit brittle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to RDF4J 5.0.2
4 participants