Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to rename pods and svc in roc-umbrella #3

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SeanCondon
Copy link
Contributor

No description provided.

@SeanCondon SeanCondon self-assigned this May 21, 2024
@SeanCondon SeanCondon added WIP Work in progress DNM Do Not Merge labels May 21, 2024
@SeanCondon SeanCondon marked this pull request as draft May 21, 2024 19:33
@gab-arrobo
Copy link
Contributor

gab-arrobo commented May 22, 2024

@SeanCondon, I think there is a simpler solution that can be applied directly in OnRamp
Before (current OnRamp)
image

After the change in OnRamp
image

This would be the change to be applied in OnRamp

diff --git a/roles/roc/tasks/install.yml b/roles/roc/tasks/install.yml
index b0755e6..5e6ec66 100644
--- a/roles/roc/tasks/install.yml
+++ b/roles/roc/tasks/install.yml
@@ -75,7 +75,7 @@
 - name: deploy aether-roc-umbrella from {{ amp.aether_roc.helm.chart_ref }}
   kubernetes.core.helm:
     update_repo_cache: true
-    name: aether-roc-umbrella
+    name: roc
     release_namespace: aether-roc
     create_namespace: true
     chart_ref: "{{ amp.aether_roc.helm.chart_ref }}"

What do you think?

@gab-arrobo
Copy link
Contributor

Probably, a change to be made here (in this Helm Charts) is to remove the .Release.Name prefix from any pod/service that already has roc in its name. What do you think?

@SeanCondon
Copy link
Contributor Author

@gab-arrobo I'm not clear if you want to keep any prefix or not. roc looks better than aether-roc-umbrella. It would certainly make it easier than remove the prefix altogether which I was trying to do.

@gab-arrobo
Copy link
Contributor

@gab-arrobo I'm not clear if you want to keep any prefix or not. roc looks better than aether-roc-umbrella. It would certainly make it easier than remove the prefix altogether which I was trying to do.

Sorry for the confusion @SeanCondon. The idea would be to remove the prefix from pod/service/etc. that already has roc in its name but it would be good to keep the .Release.Name prefix (i.e., roc) for the ROC components that do not have roc in their name. For example, remove the prefix from aether-roc-api because it already has roc in its name but keep the prefix for the sdcore-adapter such that people can relate/know that this component is part of the roc (e.g., roc-sdcore-adapter). What do you think? Does it make sense?

@SeanCondon SeanCondon changed the title trying to remane pods and svc in roc-umbrella trying to rename pods and svc in roc-umbrella Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM Do Not Merge WIP Work in progress
Development

Successfully merging this pull request may close these issues.

2 participants