Fix bugs on 64-bit machines #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ahh one more thing. This was not tested on a 32-bit machine. Only 64-bit. |
justmd5
approved these changes
Oct 7, 2016
|
This is probably still buggy. Try encoding Fails both on a 64-bit Linux and modern Win64 build of PHP 7.x for me, but I've chosen to live with it for now, as I'm only using this to encode < 32-bit numbers. |
Add support for str8/bin8/16/32 types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for posting this code!
We found a bug on 64-bit machines, where
int16andint32types were being decoded incorrectly. The bug fix is this commit:client9@0cb38ce
The other commits do the following:
thanks again!
n