Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade onionwrapper to 0.1.0 and snowflake to 2.9.1 #123

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

akwizgran
Copy link
Collaborator

No description provided.

@akwizgran akwizgran requested a review from grote March 9, 2024 20:49
@grote
Copy link
Collaborator

grote commented Mar 12, 2024

Thanks a lot! The CI doesn't like TorManager.kt:6:1 Unused import.

@grote
Copy link
Collaborator

grote commented Mar 12, 2024

Do we need a separate ticket for dealing with latest moat answers?

@akwizgran
Copy link
Collaborator Author

The CI doesn't like TorManager.kt:6:1 Unused import.

Oops, I normally have that set up as a commit action, but not on this project. Fixed.

@akwizgran
Copy link
Collaborator Author

Do we need a separate ticket for dealing with latest moat answers?

I think upgrading snowflake to 2.9.1 should allow us to handle the new fronts parameter (multiple front domains).

OnionShare uses Azure as the front for moat itself, so I think it should still be working despite the Fastly breakage. Would be good to test though.

As a future improvement, we could consider picking the moat front domain based on the country: the snowflake/meek fronts returned by moat seem to suggest that the Azure front is blocked in some countries. Might be good to find out how Tor Browser handles this.

@grote grote merged commit 32055c8 into onionshare:main Mar 12, 2024
1 check passed
@akwizgran akwizgran deleted the onionwrapper-0.1.0 branch March 12, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants