Merge pull request #101 from grote/95-proguard-netty

Add important proguard rules to keep Netty classes
onionshare · Aug 18, 2023 · c0f9381 · c0f9381
2 parents afd9531 + d0fbfa8
commit c0f9381
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -44,7 +44,7 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
         }
         debug {
-            minifyEnabled false
+            minifyEnabled true
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
         }
         benchmark {

diff --git a/app/proguard-rules.pro b/app/proguard-rules.pro
@@ -21,8 +21,26 @@
 #-renamesourcefileattribute SourceFile
 
 -dontobfuscate
+-keepattributes SourceFile, LineNumberTable, *Annotation*, Signature, InnerClasses, EnclosingMethod
+
 -keep class org.onionshare.android.** { *; }
 -keep class org.torproject.jni.** { *; }
 
--keep class ch.qos.** { *; }
--keep class org.slf4j.** { *; }
+# Keep logging
+-keep public class org.slf4j.** { *; }
+-keep public class ch.qos.logback.** { *; }
+
+# Keep Netty classes that are loaded via reflection
+-keep class io.netty.util.ReferenceCountUtil { *; }
+-keep class io.netty.buffer.WrappedByteBuf { *; }
+
+-dontwarn com.fasterxml.jackson.databind.ext.Java7SupportImpl
+-dontwarn io.netty.internal.tcnative.*
+-dontwarn java.lang.management.*
+-dontwarn org.apache.log4j.*
+-dontwarn org.apache.logging.log4j.**
+-dontwarn org.conscrypt.*
+-dontwarn org.eclipse.jetty.npn.*
+-dontwarn org.jetbrains.annotations.*
+-dontwarn reactor.blockhound.integration.BlockHoundIntegration
+-dontwarn javax.mail.**