Add secure random range reference #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
reviewed
Sep 24, 2024
| */ | ||
| function _aggregateRevertibleRandom256() private view returns (uint256) { | ||
| // Call _revertibleRandom() 4 times to aggregate 256 bits of randomness | ||
| uint256 randomValue = uint256(_revertibleRandom()); |
There was a problem hiding this comment.
In the case of revertibleRandom, there is no need to create a PRG, because revertibleRandom already behaves like one (actually there is an internal PRG in FVM). Each time you call it, the PRG squeezes out a new random
joshuahannan
approved these changes
Sep 24, 2024
Co-authored-by: Tarak Ben Youssef <[email protected]>
|
@tarakby I've done my best to implement your suggestions, including a Solidity port of the Cadence xorshift128+ implementation. Please lmk if I missed anything |
joshuahannan
approved these changes
Sep 27, 2024
tarakby
reviewed
Sep 28, 2024
tarakby
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Description