Extend AccountPublic to allow retrieval of Factory and Filter capabilities #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 82.50% 82.31% -0.19%
==========================================
Files 4 4
Lines 343 345 +2
==========================================
+ Hits 283 284 +1
- Misses 60 61 +1
|
…ter capabilities. Without this, it's very difficult to detect whether a certain capability is allowed to be retrieved unless you run scripts manually. With helper method like this (I'm sure others will be needed), you can borrow and return details of the filter/factory yourself and then process them offline
austinkline
force-pushed
the
factory-filter-cap-getters
branch
from
150783f
to
1151139
Compare
|
Sorry for the delay, addressed comments @sisyphusSmiling |
sisyphusSmiling
approved these changes
Sep 6, 2023
|
FYI these updates have been deployed in the following transactions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it's very difficult to detect whether a certain capability is allowed to be retrieved unless you run scripts manually. With helper methods like this (I'm sure others will be needed), you can borrow and return details of the filter/factory yourself and then process them offline