Skip to content

Commit

Permalink
Merge pull request #35 from onflow/janez/blockevent-timestamp-missing…
Browse files Browse the repository at this point in the history
…-converison-fix

Fixed a missed conversion of block events timestamps
  • Loading branch information
Kay-Zee authored Oct 3, 2020
2 parents a3263b5 + 4821cb3 commit 5d1df06
Showing 1 changed file with 29 additions and 11 deletions.
40 changes: 29 additions & 11 deletions access/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package access
import (
"context"

"github.com/golang/protobuf/ptypes"
"github.com/onflow/flow/protobuf/go/flow/access"
"github.com/onflow/flow/protobuf/go/flow/entities"
"google.golang.org/grpc/codes"
Expand Down Expand Up @@ -365,8 +366,12 @@ func (h *Handler) GetEventsForHeightRange(
return nil, err
}

resultEvents, err := blockEventsToMessages(results)
if err != nil {
return nil, err
}
return &access.EventsResponse{
Results: blockEventsToMessages(results),
Results: resultEvents,
}, nil
}

Expand All @@ -390,8 +395,13 @@ func (h *Handler) GetEventsForBlockIDs(
return nil, err
}

resultEvents, err := blockEventsToMessages(results)
if err != nil {
return nil, err
}

return &access.EventsResponse{
Results: blockEventsToMessages(results),
Results: resultEvents,
}, nil
}

Expand All @@ -417,25 +427,33 @@ func blockHeaderResponse(header *flow.Header) (*access.BlockHeaderResponse, erro
}, nil
}

func blockEventsToMessages(blocks []flow.BlockEvents) []*access.EventsResponse_Result {
func blockEventsToMessages(blocks []flow.BlockEvents) ([]*access.EventsResponse_Result, error) {
results := make([]*access.EventsResponse_Result, len(blocks))

for i, block := range blocks {
results[i] = blockEventsToMessage(block)
event, err := blockEventsToMessage(block)
if err != nil {
return nil, err
}
results[i] = event
}

return results
return results, nil
}

func blockEventsToMessage(block flow.BlockEvents) *access.EventsResponse_Result {
func blockEventsToMessage(block flow.BlockEvents) (*access.EventsResponse_Result, error) {
eventMessages := make([]*entities.Event, len(block.Events))
for i, event := range block.Events {
eventMessages[i] = convert.EventToMessage(event)
}

return &access.EventsResponse_Result{
BlockId: block.BlockID[:],
BlockHeight: block.BlockHeight,
Events: eventMessages,
timestamp, err := ptypes.TimestampProto(block.BlockTimestamp)
if err != nil {
return nil, err
}
return &access.EventsResponse_Result{
BlockId: block.BlockID[:],
BlockHeight: block.BlockHeight,
BlockTimestamp: timestamp,
Events: eventMessages,
}, nil
}

0 comments on commit 5d1df06

Please sign in to comment.