-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on React internals #151
base: master
Are you sure you want to change the base?
Conversation
eb08956
to
1824dba
Compare
I like the suggestion @tschaub 👍 Would you mind rebasing this and I can take a closer look at this too. |
1824dba
to
0a60670
Compare
@AlanFoster - rebased. Thanks for checking it out. |
@AlanFoster - let me know if you think this should be handled another way. |
Is there a way I can help get this in? Curious if anybody else is also interested in using React from a CDN (or separate bundle) and this date picker together. |
It looks like this will even be more important for people upgrading React (when internal lib modules are moved or changed). See facebook/react#7770 (comment). |
To be fair, addons imported via packages will keep on working. If you don't use Still, I would suggest using |
@tschaub I've been merging a lot of PRs for a 2.x release; Mind re-basing this, and we can get this shipped? 👍 |
0a60670
to
c25058a
Compare
c25058a
to
cd72634
Compare
@AlanFoster rebased (after a long delay). This uses the existing |
I'm hoping you'd be willing to move away from the dependency on
react-addons-pure-render-mixin
. Since this module requires functionality from React internals (react/lib/ReactComponentWithPureRenderMixin
), it makes it so an application cannot usereact-daterange-picker
and load React from a CDN.Since there is already a
PureRenderMixin
in this package, one alternative would be to use that. Or, since this does additional checks for moment, things could be split into one mixin for shallow comparisons with moment and one mixin for shallow comparisons without moment.I'll be happy to make changes to this if you're interested in moving away from
react-addons-pure-render-mixin
.