[Cuda] Simplify and optimise the getMaxRegistersJitOptionValue
utility
#2110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the
getMaxRegistersJitOptionValue
function as it was previously unclear what the return bool value actually meant, because it doesn't really signify whether the value was valid or not but it was more of a whether the parsing was successful. Instead, we now just return the parsed value if it is successfully parsed, otherwise we return the default.Additionally, we replace the use of
std::stoi
withstd::from_chars
which is much lighter weight (and works well withstd::string_view
s), in order to avoid extra dynamic allocation(s).