Reflect upstream OpenCL command-buffer API changes #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
command-buffer
Update OpenCL adapter code to reflect the 2 API breaking changes to the command-buffer family of extensions that have been made upstream: * [Add properties parameter to all command-buffer commands](KhronosGroup/OpenCL-Headers#260) * [Use array for clUpdateMutableCommandsKHR](KhronosGroup/OpenCL-Headers#245)
EwanC
force-pushed
the
ewan/update_opencl_headers
branch
from
050919c
to
762eb9f
Compare
aarongreig
approved these changes
Sep 17, 2024
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Sep 17, 2024
Update UR commit for L0 adapter to use most recent Khronos cl_khr_command_buffer APIs oneapi-src/unified-runtime#2095
fabiomestre
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OpenCL adapter code to reflect the 2 API breaking changes to the command-buffer family of extensions that have been made upstream:
PR also contains fixes for CTS tests that have been added recently:
urCommandBufferAppendKernelLaunchExpchecks for nullptrurCommandBufferAppendMemBufferWriteExpdoesn't die (other unsupported commands in the adapter don't do this)DPC++ PR intel/llvm#15410